Yann Dirson wrote:
Author: ydirson
Date: Mon Oct 31 00:46:28 2005
New Revision: 8675
URL: http://svn.gna.org/viewcvs/wesnoth?rev=8675&view=rev
Log:
dependency cleanup: splitted preferences.* into preferences_display.*, so that
modules which only need to query a prefs value do not depend on the whole
graphics system
Added:
trunk/src/preferences_display.cpp (with props)
trunk/src/preferences_display.hpp (with props)
Urgh, this is evil :(
I'm currently rewriting the video driver system so that it works with
OpenGL. The problem is that I've done much changes in preferences.cpp,
notably in the display part of preferences. You split will create a big
fat conflict which will take much work to resolve.
Working around dependency problems is good, and I thank you for that,
but... Those changes seem very radical, and are likely to cause huge,
hard to solve conflicts to anybody working on the same files. The split
of "font" already created many conflicts on my development copy, for no
real advantage because my changes made it nearly useless (font
operations DO depend on video).
Maybe such changes ought to be discussed, or at least announced, before
being made?
Cheers,
Ayin
