On Sun, Jul 12, 2009 at 11:26:03PM +0300, Oron Peled wrote: > First, tons of apologies for responding so slow. > I found (after Mark CC'ed me on one of the mails) that I'm not > subscribed to wesnoth-dev (wasn't active for the last two years or so). > > * loonycyborg fixed (correctly) <fribidi/fribidi.h> to <fribidi.h> > but this broke compilation for Mark -- which means 0.10.9 should > be handled differently.
Since you didn't change the include I assumed it worked properly but if the correct way is to use #include <fribidi.h>, I can have a look at whether it's fixable for cmake. I prefer not to backport this to 1.6 or 1.4 since I don't want to risk breaking stable releases. > > Mark de Wever <[email protected]> wrote: > > Debian doesn't ship fribidi 0.19 so I can no longer use fribidi for > > Wesnoth. Oron please add conditional code to work with both APIs. > > Debian lenny carries wesnoth-1.4 (didn't touch it) and lenny-backports > carries wesnoth-1.6.2 (also untouched yet). However, you are totally > correct that this situation calls for conditional code. Some Debian Lenny users compile (I also use Debian Lenny). Also our server runs Debian Lenny (not really relevant for this change). In general I consider Debian stable to be a good baseline for dependencies. Since we don't know what our users exactly use and since Debian stable is rather conservative we can expect most users to have the same or newer libraries. > To prevent further blunders I would like to send the proposed patches > for review of the interested parties before committing them (Mark, > Sergey, with your permission. Anybody else interested, just ping me > privately). I wouldn't call it a blunder, just a mistake. If you feel more comfortable to send patches you can do so, but I don't want to require it of you. > > Nils Kneuper on July 11, 2009 - 11:07: > > Ahhh, several problems with this: > > 1) Starting with 1.6.x fribidi is basically deprecated and only used in > > the "old" gui elements. No idea if the change is still relevant. > > Mordante knows more about this. > > Deprecated? What should users of bidi languages (Hebrew/Arabic/Farsi) to do? > Mordante, if you can shed some light on this it would be greatly appreciated. <snip> > So: > - Killing fribidi -- no wesnoth for Hebrew/Arabic/Farsi. > - Killing rtl -- wesnoth can still be played but looks bit > awkward (wrong justification) -- can be tolerated until > adaptation to new widget system is being developed. Actually the reason to deprecate fribidi is to improve the display of Arabic ;-) I've been working on a new widget system and started to use fribidi and SDL_TTF like to old widgets. But somebody complained that Arabic text was rendered per letter and not written together as it's supposed to be. Since SDL_TTF doesn't support that I decided to look for some library that does and decided to use Pango. Also for your information, I really don't want to reduce the amount of users that are able to play Wesnoth in their native tongue. I like to work on increasing that number, by making sure the infrastructure is there. > BTW: if the widgets are going to be rewritten, it would make life *A LOT* > easier if each of them has a correct clipping rectangle -- one of > the hardest jobs I had back then, was to fix the clipping rectangles > which were originally from the top/left corner of the widget to the > bottom/right corner of the *screen* -- this mistake didn't affect > left justified text (e.g: English), but completely relocated right > justified text until I fixed it. That's supposed to work in the new widgets, but since I don't understand any rtl language I can't really test it. Which leads me to another question; I saw you committed a Hebrew translation update and that you're listed as the maintainer of the Hebrew translation. Are you willing to test whether translations and text input properly works with the new widgets? If you want to, we can discuss the details further via email or on #wesnoth-dev (where I'm most of the time in the evening (GMT +2). -- Regards, Mark de Wever aka Mordante/SkeletonCrew _______________________________________________ Wesnoth-dev mailing list [email protected] https://mail.gna.org/listinfo/wesnoth-dev
