hi to hrvoje and all, i am still alive ;-) and i am finally catching up
with the changes you've done at wget ipv6 code. from what i've seen so
far, it seems that you've done a great job (especially on lookup_host and
resolve_bind_address and on the transport_map)!!!
only a few suggestions:
change this code in address_list_contains:
if (cur->type == IPV4_ADDRESS
&& (ADDRESS_IPV4_IN_ADDR (cur).s_addr
==
ADDRESS_IPV4_IN_ADDR (ip).s_addr))
to the more readable:
if (cur->type == IPV4_ADDRESS
&& (ADDRESS_IPV4_IN_ADDR (cur).s_addr
== ADDRESS_IPV4_IN_ADDR (ip).s_addr))
and rename address_list_connected_p to address_list_is_connected.
now we have to add the checks for sockaddr_storage in configure.in.
what about adding this test (taken from nc6):
AC_DEFUN([TYPE_STRUCT_SOCKADDR_STORAGE],[
ds6_have_sockaddr_storage=
AC_CHECK_TYPES([struct sockaddr_storage],[
ds6_have_sockaddr_storage=yes
],[
ds6_have_sockaddr_storage=no
],[
#include <sys/types.h>
#include <sys/socket.h>
])
if test "X$ds6_have_sockaddr_storage" = "Xyes"; then :
$1
else :
$2
fi
])
to aclocal.m4, adding the test:
TYPE_STRUCT_SOCKADDR_STORAGE(AC_DEFINE(HAVE_STRUCT_SOCKADDR_STORAGE, 1,
"Define if the system supports struct sockaddr_storage."))
to configure.in and changing:
#ifndef ENABLE_IPV6
# ifndef HAVE_SOCKADDR_STORAGE
# define sockaddr_storage sockaddr_in
# endif
#endif /* ENABLE_IPV6 */
to:
#ifndef ENABLE_IPV6
# ifndef HAVE_STRUCT_SOCKADDR_STORAGE
# define sockaddr_storage sockaddr_in
# endif
#endif /* ENABLE_IPV6 */
in connect.h?
i would also suggest renaming configure.in to configure.ac...
BTW, i'm doing few more tests on ftp support. after those tests, hrvoje,
i'll let you delete all those ugly assertions in the ftp code :-)
--
Aequam memento rebus in arduis servare mentem...
Mauro Tortonesi [EMAIL PROTECTED]
[EMAIL PROTECTED]
[EMAIL PROTECTED]
Deep Space 6 - IPv6 with Linux http://www.deepspace6.net
Ferrara Linux User Group http://www.ferrara.linux.it
