Stepan Kasal <[EMAIL PROTECTED]> writes: > 1) I removed the AC_DEFINEs of symbols HAVE_GNUTLS, and HAVE_OPENSSL. > AC_LIB_HAVE_LINKFLAGS defines HAVE_LIBGNUTLS and HAVE_LIBSSL, which > can be used instead. wget.h was fixed to expect these symnbols. > (You might think your defines are more aptly named, but they are used > only once, in wget.h.)
You're right. While I do prefer the old names, it's not that big a deal and it doesn't make sense to needlessly duplicate the defines. > 2) Was it intentional that --without-ssl doesn't switch off OpenSSL > autodetection? I hope it wasn't. Definitely not. > 3) Explicit --with-ssl=gnutls should fail if libgnutls is not found. > If the user explicitely asked for it, we shouldn't silently ignore the > request if we cannot fulfill it. > And likewise with "./configre --with-ssl". Agreed. > (I know this is not common practice (yet), but I believe it's > according to common sense. Wget 1.10 did this. The feature got lost when moving to AC_LIB_HAVE_LINKFLAGS.
