-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Philip Gladstone wrote: > Micah Cowan wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> Philip Gladstone wrote: >> >>> Brief outline: >>> >>> When you do a wget from an ftp: url, it tries to copy over the last >>> modified date of the file (this is good). However, due to timezone >>> issues, the date that it gets can sometimes be in the future, and then >>> it guesses the year incorrectly. This patch fixes that problem. >>> >> >> (See original message, with patch, at >> http://article.gmane.org/gmane.comp.web.wget.patches/2224) >> >> Good catch. >> >> However, on closer inspection, this patch doesn't quite fix the problem, >> properly. It checks whether the file's time is in the first day of the >> next month, but not whether the _current_ time is the last day of the >> current month. We need to do a stronger check for whether it's truly >> within 24 hours of the current time. > > If you go that far, then you need to allow for the fact that local times > can be (AFAIK) 25 hours apart in the worst case. If you want to allow > for clock skew as well, then probably more than 25 hours would be a > sensible amount. Maybe 96 hours.
I think 24 hours is reasonable; it's a guess in any case. But I do think that, if today is December 3, and the file is January 1, it should be considered to use the current year (while the patch, as it stands, would automatically consider it to be Jan 1 of next year). - -- Micah J. Cowan Programmer, musician, typesetting enthusiast, gamer... http://micah.cowan.name/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHWzre7M8hyUobTrERAuTdAKCGwei4rx9zZUmGDxgtNjYQm4aHkQCbBJMb 1YI/1C/J2kXoI13jTppnXKs= =T02u -----END PGP SIGNATURE-----
