-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hrvoje Niksic wrote: > Micah Cowan <[EMAIL PROTECTED]> writes: > >> Rather than disable NLS altogether if wcwidth or mbtowc are missing, >> I've opted to disable NLS support only for the progress bar itself: > > Nice! Progress bar's usage of multibyte functions is quite localized, > so it makes sense to do this. My proposal assumed more widespread use > of multibyte functions in other contexts.
Yeah; and at some point there probably will be more widespread use (particularly if we do decide to do some transcoding, etc). I'm a little unhappy with the change just because it assumes that with_thousands_sep is only ever used for the progress bar, which may not always be true... but it _is_ currently, and meantime this was the quickest/least-risky way to do what I wanted, while still keeping NLS support where feasible. > BTW I believe Windows doesn't have wcwidth -- we probably shouldn't > disable NLS progress bar if only wcwidth is missing. Except, I believe that the Windows builds don't normally include NLS support (windows/config.h has HAVE_NLS commented out). Enabling it would require the user to go fetch and install libintl, I think. Chris, can you confirm this? I'm not sure I want to worry too much about not having the progress-bar stuff translated when wcwidth is missing, though: after all, it's just the separator character (for which comma or dot should do fine, I think) and "eta". And I know that ja_JP will lose if I were to enable progress-bar translation without wcwidth support (though I don't know of any other locales that use fullwidth characters in the progress bar; the Chinese ones don't have translations for "eta"). - -- Micah J. Cowan Programmer, musician, typesetting enthusiast, gamer... http://micah.cowan.name/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFHqsGj7M8hyUobTrERAlFLAJ9fKIkPHIGHOQ6lWyuzGd2p8cCAAgCaAyuN /wX89fZjJ/d59cXljVk0SkY= =QziX -----END PGP SIGNATURE-----
