-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Alain Guibert wrote: > Hello, > > With an old gcc 2.7.2.1 compiler, wget 1.11.1 make test fails: > > | gcc -I. -I. -I./../src -DHAVE_CONFIG_H > -DSYSTEM_WGETRC=\"/usr/local/etc/wgetrc\" > -DLOCALEDIR=\"/usr/local/share/locale\" -O2 -Wall -DTESTING -c ../src/test.c > | ../src/test.c: In function `all_tests': > | ../src/test.c:51: parse error before `const'
<snip> > The attached make-test.patch seems to fix this. Yeah; that's invalid C90 code; declaration following statement. I'll fix that. > However later the 3rd > test fails: > > | ./unit-tests > | RUNNING TEST test_parse_content_disposition... > | PASSED > | > | RUNNING TEST test_subdir_p... > | PASSED > | > | RUNNING TEST test_dir_matches_p... > | test_dir_matches_p: wrong result > | Tests run: 3 > | make[1]: *** [run-unit-tests] Error 1 > | make[1]: Leaving directory `/tmp/wget-1.11.1/tests' > | make: *** [test] Error 2 That's an interesting failure. I wonder if it's one of the new cases I just added... In any case, it runs through fine for me. This suggests a difference in behavior between your system fnmatch function and mine (since that should be the only bit of external code that dir_matches_p relies on). Pity the tests don't give much clue as to the specifics of what failed... there are about 10 tests for test_dir_matches_p, any of which could have caused the problem. The whole testing thing needs some serious rework; which is my current top priority, when I find time for it (GSoC is eating everything, right now). "make test" isn't actually expected to work completely, right now; some of the .px tests are known to be broken/missing. They're basically provided "as-is". I thought about removing them for the official package; maybe I should have. But if I had, I'd still be blissfully unaware of this potential problem. If you know how, and don't mind, could you try to isolate which part of test_dir_matches_p is failing? Perhaps augmenting the error message to spit the match-list and string arguments... - -- Thanks, Micah J. Cowan Programmer, musician, typesetting enthusiast, gamer, and GNU Wget Project Maintainer. http://micah.cowan.name/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFH8S/v7M8hyUobTrERAhrPAJ9N+XqLeVP0NN9HkLxO162Zf2uJnACeMwUo kew/FkMA2GljqWiPG6IC+zs= =fQSH -----END PGP SIGNATURE-----
