[
https://issues.apache.org/jira/browse/WHIRR-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970975#action_12970975
]
Tom White commented on WHIRR-160:
---------------------------------
This looks good so far. A few comments:
* You can use KeyPair in the org.apache.whirr.ssh test package to generate keys
for DestroyClusterCommandTest and LaunchClusterCommandTest.
* It would be good to have some tests for file existence, i.e. fail early if
either key doesn't exist.
* I think we default the private key to ${sys:user.home}/.ssh/id_rsa and the
public key to ${sys:user.home}/.ssh/id_rsa.pub (see
core/src/main/resources/whirr-default.properties). I think the public key
should actually default to the private key + ".pub". Can we make this change
(with tests) here too?
BTW you could do the check that both keys belong to the same pair in another
JIRA if it is more involved, since the rest is useful enough to go in by itself
I think.
> Improve SSH key diagnostics
> ---------------------------
>
> Key: WHIRR-160
> URL: https://issues.apache.org/jira/browse/WHIRR-160
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Reporter: Tom White
> Fix For: 0.3.0
>
> Attachments: WHIRR-160.patch
>
>
> This would reduce the number of support issues that trip up users.
> We already check that the private and public keys both exist (but I don't
> think we have a unit test for that).
> In addition, we should
> * Check that the private key is passwordless (see how at
> http://incubator.apache.org/whirr/faq.html#Can_I_specify_my_own_private_key).
> * Check that the private and public keys belong to the same pair (via, e.g.
> http://s.apache.org/MNY).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
