[
https://issues.apache.org/jira/browse/WHIRR-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972232#action_12972232
]
Tom White commented on WHIRR-156:
---------------------------------
There's no real difference in this case, since the glob patterns match 0 or 1
files. The ls approach is preferable when there are multiple glob matches. Your
code is slightly shorter, so perhaps we can use that?
You can test it by running "bin/whirr" from both a source directory, and from
an unpacked tarball built with "mvn package assembly:assembly".
> Cli script doesn't launch post-modularization
> ---------------------------------------------
>
> Key: WHIRR-156
> URL: https://issues.apache.org/jira/browse/WHIRR-156
> Project: Whirr
> Issue Type: Bug
> Components: cli
> Reporter: Stu Hood
> Fix For: 0.3.0
>
> Attachments: WHIRR-156.patch, WHIRR-156.patch
>
>
> bin/whirr is looking for the cli jar in the wrong location: the following
> change works, but would not be forwards compatible:
> {code}-java -jar $bin/../whirr-cli-*.jar "$@"
> +java -jar $bin/../cli/target/whirr-cli-*-incubating-SNAPSHOT.jar "$@"{code}
> Note that the naive forwards compatible approach grabs the source jar instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
