[ 
https://issues.apache.org/jira/browse/WHIRR-168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993961#comment-12993961
 ] 

Tom White commented on WHIRR-168:
---------------------------------

> I think so, because on the server side we don't want to add a 
> hadoop.socks.server property.

Yes, I think that's right (I had mistakenly thought that it was also needed 
server side when I made my comment above). For client side properties, we have 
a convention of whirr.<service-name> (see HBaseConstants for some examples), so 
you should follow that for the socks address. 

The NPE is caused because whirr-hadoop-default.properties is not being read in 
the handler. HBase has some code in 
HBaseClusterActionHandler#getConfiguration() to combine the cluster spec with 
the service defaults. I think something similar would work here. In fact, this 
is exactly what is needed for WHIRR-222, and probably other services. We should 
pull up getConfiguration() to ClusterActionHandlerSupport - with an extra 
default service Configuration that is passed by the service. However, I don't 
think that's needed in this patch, so we can do it elsewhere.


> Add a new optional c parameter for being able to configure the port of socks 
> connection.
> ----------------------------------------------------------------------------------------
>
>                 Key: WHIRR-168
>                 URL: https://issues.apache.org/jira/browse/WHIRR-168
>             Project: Whirr
>          Issue Type: New Feature
>          Components: core, service/hadoop
>         Environment: ec2
>            Reporter: Tibor Kiss
>            Assignee: Tibor Kiss
>            Priority: Minor
>         Attachments: local-socks-proxy-address.patch
>
>
> We have a generated .whirr/<hadoop-cluster-name>/hadoop-proxy.sh which 
> contains a hard coded port value, the 6666.
> In order to be able to start multiple clusters from the same console I needed 
> a simple mechanism to be able to parametrize this port number.
> Therefore I made a patch which adds the possibility to set this 
> 'whirr.local-socks-proxy-address' to something like
> whirr.local-socks-proxy-address=localhost:6666
> Instead of configuring the port, we are able to configure the address which 
> contains the port.
> (also for the sourcecode, it looks much better to not have such a hardcoded 
> value.)
> In order to run multiple clusters you only need to override this paramter 
> knowing that the default value is localhost:6666

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to