[
https://issues.apache.org/jira/browse/WHIRR-237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001782#comment-13001782
]
Tom White commented on WHIRR-237:
---------------------------------
Generally looks good. A few comments:
* You don't need VoldemortClientService and VoldemortService since everything
is role based now.
* Change "voldemortclient" to "voldemort-client" by analogy with "hbase-master"
etc.
* Change "whirr.voldemort-tar-url" to "whirr.voldemort.tarball.url" for
consistency with other services, like HBase. There are other properties that
should be changed too, and you might consider putting them in a constants class
(like HBaseConstants) to avoid duplication.
* There's a spurious reference to Cassandra in pom.xml.
* There are some tabs and inconsistent indentation (should be 2 spaces) in
places.
* Try running "mvn checkstyle:checkstyle apache-rat:check" to test for style
and licensing compliance.
Thanks for contributing this!
> Add Voldemort as a service
> --------------------------
>
> Key: WHIRR-237
> URL: https://issues.apache.org/jira/browse/WHIRR-237
> Project: Whirr
> Issue Type: New Feature
> Components: core
> Reporter: Roshan Sumbaly
> Priority: Minor
> Attachments: WHIRR-237.v1.patch, WHIRR-237.v2.patch,
> linkedin-voldemort-0.90.RC3.jar
>
>
> Add Voldemort as a service to Whirr. We have a first version (
> https://github.com/rsumbaly/whirr/tree/voldemort ) and another one with more
> features from Kirk ( https://github.com/kirktrue/whirr/tree/voldemort) - More
> description (
> https://groups.google.com/forum/?pli=1#!topic/project-voldemort/l6rb2X7YXEM )
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
