[ 
https://issues.apache.org/jira/browse/WHIRR-220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017545#comment-13017545
 ] 

Tom White commented on WHIRR-220:
---------------------------------

Thanks for the new patch Andrei. I'm not sure about adding the HttpRequest to 
the Configuration object. I think we should avoid adding complex objects to 
configuration (even though it's only used internally), since configurations 
should be easily serialized. How about having the cluster action handlers 
upload the tarball, and add the retrieve statement to the statement list? The 
blobstore container name can be added to the configuration (as a string), and 
deleted on teardown.

A few other comments:
* TemporaryBlobStore#uploadLocalFiles will upload anything whose value begins 
with "file://". We should really only upload known artifacts, governed by key. 
This would not be a problem with the approach described above.
* Unless there's a strong reason to do it here, it might be simpler to move 
InstanceTemplate to a top-level class in a separate JIRA.
* Add the new blobstore files in ClusterSpec to its equals, hashCode and 
toString methods.

> Support local tarball upload
> ----------------------------
>
>                 Key: WHIRR-220
>                 URL: https://issues.apache.org/jira/browse/WHIRR-220
>             Project: Whirr
>          Issue Type: New Feature
>          Components: service/cassandra, service/hadoop
>            Reporter: Tom White
>            Assignee: Andrei Savu
>             Fix For: 0.5.0
>
>         Attachments: BlobCopyOperation.java, WHIRR-220.patch, 
> WHIRR-220.patch, WHIRR-220.patch, WHIRR-220.patch, WHIRR-220.patch, 
> WHIRR-220.patch, WHIRR-220.patch, WHIRR-220.patch
>
>
> If the installation tarball URL is a file:// URL then Whirr could upload it 
> to a blobstore and automatically download it onto the instances before 
> running the install script. This change would make it very easy to test 
> development versions of Hadoop, or other services. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to