[
https://issues.apache.org/jira/browse/WHIRR-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13017778#comment-13017778
]
Patrick Hunt commented on WHIRR-275:
------------------------------------
changes for 1/2 look good.
However on 3, I think it's more natural to have a collection, no? Say you have
quite a few rules, or perhaps you want to call one or more methods to create
those rules, you'd want to collect them up in.. a collection, and pass that to
addRules. Optionally you could just call addRule(rule) multiple times. My
suggestion re guava was related to this - it has nice ways to create sets by
doing something like "...addRules(ImmutableSet.of(rule1, rule2, rule3))
> Improve firewall API for services
> ---------------------------------
>
> Key: WHIRR-275
> URL: https://issues.apache.org/jira/browse/WHIRR-275
> Project: Whirr
> Issue Type: Improvement
> Reporter: Tom White
> Fix For: 0.5.0
>
> Attachments: WHIRR-275.patch, WHIRR-275.patch, WHIRR-275.patch
>
>
> The API that services use to configure firewall settings is pretty verbose.
> It would be nice to improve it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
