[ 
https://issues.apache.org/jira/browse/WHIRR-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13033069#comment-13033069
 ] 

Andrei Savu commented on WHIRR-294:
-----------------------------------

Looks good but I believe that some of the start functions are doing a bit too 
much (e.g. start_namenode is doing setup work, cdh start_hadoop_daemon 
installing services). We should move that code to the install / configure 
functions so that we can reuse the start / stop functions when updating the 
configuration or doing rolling restarts. 

> Separate Hadoop install and configuration scripts into more generic functions 
> ------------------------------------------------------------------------------
>
>                 Key: WHIRR-294
>                 URL: https://issues.apache.org/jira/browse/WHIRR-294
>             Project: Whirr
>          Issue Type: Sub-task
>          Components: service/hadoop
>            Reporter: Andrei Savu
>            Assignee: Tom White
>             Fix For: 0.5.0
>
>         Attachments: WHIRR-294.patch, WHIRR-294.patch
>
>
> Separate Hadoop install and configuration scripts into more generic functions.
> We should have something like: 
> {start,stop,install,configure,cleanup}_hadoop
> Naming consistency would be helpful.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to