[
https://issues.apache.org/jira/browse/WHIRR-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085495#comment-13085495
]
Adrian Cole commented on WHIRR-361:
-----------------------------------
Please figure out a way to get the attached ConfigureClusterAction passing
checkstyle, as it took a while to refine, but maven isn't telling me what is
wrong with it.
ok. logic is failing at the following redundant check:
// Check it's the correct cluster
if (!clusterSpec.getClusterName().equals(nodeMetadata.getGroup())) {
return false;
}
we are already know it is in the cluster from the latter check on id (taken
from cluster map), so the above code is redundant.
For some reason in aws-ec2, the security group name isn't parsing properly
which is why that check is failing. I'd recommend applying the attached
version of ConfigureClusterAction, taking out the redundant cluster name check
so that aws-ec2 can work without a patch on jclouds.
I've verified the solution I'm recommending works, but please do re-check.
Also note, I am using the patch in WHIRR-341 so that I'm testing against a
stable ubuntu ami.
> refactor jclouds dependencies
> -----------------------------
>
> Key: WHIRR-361
> URL: https://issues.apache.org/jira/browse/WHIRR-361
> Project: Whirr
> Issue Type: Improvement
> Components: core
> Affects Versions: 0.6.0
> Reporter: Adrian Cole
> Assignee: Adrian Cole
> Priority: Blocker
> Fix For: 0.6.0
>
> Attachments: ConfigureClusterAction.java, WHIRR-361-fixguava.patch,
> WHIRR-361.patch,
> org.apache.whirr.service.hbase.integration.HBase089ServiceTest.txt
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> There are a few problems in our maven configuration, and a couple places
> where we aren't using the best jclouds configuration.
> * in our pom files, we needlessly declare transitive dependencies modules.
> this is unnecessary maintenance, as jclouds version/dependency configuration
> is scoped to whirr core
> * we've switched to SLF4J, yet haven't configured jclouds to use it
> * especially considering we are uploading large blobs, we should be using
> the jclouds EnterpriseConfigurationModule which handles file slicing much
> more effectively.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
