[ 
https://issues.apache.org/jira/browse/WICKET-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12465745
 ] 

Alastair Maw commented on WICKET-149:
-------------------------------------

The patch doesn't cope with mounted resources and things. Am looking into 
fixing this differently, to cope with the following scenarios (any combination 
of them):

Mounted and unmounted pages.
Mounted and unmounted resources.
filter mapping="/*" or filter mapping="/app/*" with filterPath param of  "" and 
"app" respectively.
Context path of either "/" or "/foo".

Hopefully fixing and testing all of these will make things work for everyone.

An additional wrinkle is making this also work behind a proxy, with an 
overridden Application.setContextPath(), which also appears to be failing at 
the moment with WicketFilter.

> mounted URLs fail if filterPath is blank
> ----------------------------------------
>
>                 Key: WICKET-149
>                 URL: https://issues.apache.org/jira/browse/WICKET-149
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3
>         Environment: jetty 5/6
>            Reporter: Nathan Hamblen
>         Assigned To: Alastair Maw
>             Fix For: 1.3
>
>         Attachments: slashCheck.diff
>
>
> The path in RequestParameters needs to begin with a "/" or it will not be 
> found when checking against mounted paths. The slash is prefixed in 
> WicketFilter line 545 when checking isWicketRequest(), but it is not prefixed 
> later when looking for the request target. Proposed fix in patch (to be 
> attached) performs this operation in ServletWebRequest.getPath(); I'm not 
> sure if that is the ideal spot, but I've confirmed that it fixes the problem.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to