[
https://issues.apache.org/jira/browse/WICKET-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487071
]
Eelco Hillenius commented on WICKET-435:
----------------------------------------
We had a bit of talk about the various alternatives to IWrapModel, but I think
(and a few others) this is really the best name for it. Some names are better
depending on the ocassion, but this one seems to be best in general. Changed
getNestedModel to getWrappedModel
> fix documentation errors and review models
> ------------------------------------------
>
> Key: WICKET-435
> URL: https://issues.apache.org/jira/browse/WICKET-435
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.3
> Reporter: Eelco Hillenius
> Fix For: 1.3
>
>
> Review the newly backported models for bugs in documentation. Also consider
> these remarks from this http://www.nabble.com/Model-quirks-tf3489227.html
> email:
> - PropertyModel#propertyType(Component)
> Is never called, has a @see to non existent method
> AbstractPropertyModel#propertyType(Component)
> - BoundCompoundPropertyModel#propertyType(Component)
> Ditto, makes BoundCompoundPropertyModel.Binding#type worthless
> - CompoundPropertyModel
> Since we don't have a ICompoundModel any longer, shouldn't this class be
> better named InheritablePropertyModel?
> - AttachedCompoundPropertyModel
> This inner class implements IInheritableModel, which is superfluous
> because in Component#initModel() it is tested on IWrapModel before ever
> being able to be used as an IInheritableModel.
> - IWrapModel and IWrapModel#getNestedModel()
> The name of this class and method are misguiding:
> Wrapping models inside other models is quite common in Wicket (see
> PropertyModel() javadoc).
> But this interface is mainly used as a marker for cases, where models
> are inherited "from components higher in the hierarchy" - see
> Component#initModel() and MarkupContainer#setModel().
> Why not call it IInheritedModel and #getInheritableModel() then?
> I know that the same interface is used for
> IAssingmentAwareModel#wrapOnAssignment(Component), but this method could
> equally well just return an IModel or be a #setComponent(Component).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
