I've seen the fix and I don't understand why. Please correct me if I'm wrong but you just replaced DummyApplication.java with an inline DummyWebApplication. What was the reason for the change?
Juergen On 11/7/06, Frank Bille <[EMAIL PROTECTED]> wrote:
Juergen I really don't hope you are working on it, because I have just committed the fix :S Frank On 11/7/06, Frank Bille <[EMAIL PROTECTED]> wrote: > > Right now WicketTester (src/main) uses DummyApplication (src/test). > Juergen are you looking at that or should I. > > Frank > > On 11/6/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > > just making sure you knew about it to save you some work :) > > > > -igor > > > > On 11/6/06, Juergen Donnerstag <[EMAIL PROTECTED]> wrote: > > > > > > I didn't like the patch. It only merged MockWebApplication and > > > WebTester into a single big class. The author assumed it works, but as > > > the patch didn't include the modification necessary to the existing > > > junit test cases, ... > > > > > > Juergen > > > > > > On 11/6/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > > > > didnt someone already submit a patch that does this? > > > > > > > > -igor > > > > > > > > > > > > On 11/6/06, Juergen Donnerstag <[EMAIL PROTECTED]> wrote: > > > > > > > > > > Currently MockWebApplication and WicketTester are derived from > > > > > WebApplication which requires us to copy & paste code from > > > > > MyApplication to MyWicketTester which is kind of ugly. I changed > > > > > MockWebApplication to delegate to an application instead. It seems > to > > > > > work fine but most xxxExpectedResult.html files must be changed. > > > > > Example > > > > > > > > > > <a > > > > > > > > > href="/WicketTester/WicketTester?wicket:interface=:0:link::ILinkListener" > > > > > wicket:id="link">test</a> > > > > > --- > > > > > <a > > > > > > > > > > > href="/DummyApplication/DummyApplication?wicket:interface=:0:link::ILinkListener" > > > > > wicket:id="link">test</a> > > > > > > > > > > I guess that is ok, but I want to check with you first. Any > thought? > > > > > > > > > > Juergen > > > > > > > > > > > > > > > > > > > > >
