I thought this important enough to cross-post to user and dev, sorry for the duplication if you read both.

As noted in the 1.2 -> 1.3 migration notes, EmailAddressPatternValidator has been renamed to EmailAddressValidator to better fit in with the naming conventions used elsewhere.

I've just removed the old deprecated class as I see no reason this should be hanging around in the 1.3 release.

If you've already upgraded to use this class, PLEASE PAY ATTENTION NOW:

When JBQ committed the new class, he did not update its resource key. I have recently done this, so things are consistent. You should be using the key "EmailAddressValidator" in your properties files.

If you're on Mac OS X or Linux, you can check if this affects you by running something like this over your codebase:
grep -r EmailAddressPatternValidator *

I've also taken the oppportunity to rename:
   RfcCompliantEmailAddressPatternValidator
to:
   RfcCompliantEmailAddressValidator

It's resource key has been updated similarly.

PatternValidator used to have a resourceKey() method which returned "PatternValidator". I've removed this and let it just delegate to super. This will have no effect at all for PatternValidator, but will for subclasses if you don't override the resourceKey() method.

These will now behave as you might expect, which is to say that the resource key will default to the simple name of your validator class.

This should hopefully make things more consistent and understandable for everyone, as the default behaviour will now be correct 95% of the time.

Regards,

Al
--
Alastair Maw
Wicket-biased blog at http://herebebeasties.com

Reply via email to