OK, I went looking and found:
http://svn.apache.org/viewvc/incubator/wicket/tags/wicket-1.3.0-beta2/jdk-1.
4/wicket/src/main/java/org/apache/wicket/util/file/
So you do have an old version of the FileCleaner, albeit prior to
enhancements that have been added to the current version in Commons, and you
have added some support for it to
org/apache/wicket/util/upload/DiskFileItem.java, but you also have a bogus
finalizer in DiskFileItem, and you're lacking the support code from Commons
File Upload.
I understand "we just took what little pieces we needed instead of adding a
dependency on the entire thing", but what is meant by "the code grew in a
different direction due to various reasons"?
--- Noel
-----Original Message-----
From: Igor Vaynberg [mailto:[EMAIL PROTECTED]
Sent: Thursday, July 05, 2007 12:56
To: wicket-dev@incubator.apache.org
Subject: Re: FileUploadField closing input streams behind my back
On 7/5/07, Noel J. Bergman <[EMAIL PROTECTED]> wrote:
>
> a/org/apache/commons/fileupload/
>
> Sorry if this comes across as being snarky, but rewriting the wheel is bad
> enough; getting it wrong is worse.
>
> --- Noel
actually if you take a look you will see that our upload code does come from
commons-fileupload. we just took what little pieces we needed instead of
adding a dependency on the entire thing.
-igor
-----Original Message-----
From: Eelco Hillenius [mailto:[EMAIL PROTECTED]
Sent: Thursday, July 05, 2007 12:58
To: wicket-dev@incubator.apache.org
Subject: Re: FileUploadField closing input streams behind my back
> For that matter, why aren't you using Commons? The very problem (file
> uploading) you are dickering with is precisely one that we addressed in
> Commons years ago. The core code is in Commons I/O:
>
>
http://svn.apache.org/viewvc/jakarta/commons/proper/io/trunk/src/java/org/ap
> ache/commons/io/
We have been using commons-io from the start, but the code grew in a
different direction due to various reasons.
Eelco
