I'm leaning slightly toward setStripRendantWhitespace() simply
because it is consistent with our naming convention and is clearer
up-front than "compressWhitespace".Gili On Sun, 09 Jan 2005 11:44:05 -0800, Jonathan Locke wrote: > >i'll buy that. but it's either setStripRedundantWhitespace or just >setCompressWhitespace as is (since it doesn't strip ALL whitespace, just >/redundant/ whitespace) > >Gili wrote: > >> I still want the same functionality. I am simply saying that I >>prefer using: >> >>setStripComments(boolean); >>setStripWhitespace(boolean); >>setStripWicketTags(boolean); >>setStripWicketIDs(boolean); >>setStripWicketIDPrefix(boolean); >> >> instead of a single method that that a flag as an argument. >> >>Gili >> >>On Sun, 9 Jan 2005 20:24:16 +0100, Juergen Donnerstag wrote: >> >> >> >>>Don't you want to enable/disable writing this specific tag? enable / >>>disable = true / false = flag. >>> >>>Juergen >>> >>> >>>On Sun, 09 Jan 2005 14:20:38 -0500, Gili <[EMAIL PROTECTED]> wrote: >>> >>> >>>> I'm against the use of flags. You lose compile-time type safety >>>>and this kind of code is hard to maintain over time (especially if you >>>>wish to extend the class defining the flags). For an example of what I >>>>mean, see DefaultButtonModel.java in Swing. Because they close to >>>>implement the various states through flags, it is extremely >>>>difficult/impossible to add support for a tri-state button. >>>> >>>> I would much rather we separate the various states into >>>>separate methods. >>>> >>>>Gili >>>> >>>>On Sun, 09 Jan 2005 10:45:29 -0800, Jonathan Locke wrote: >>>> >>>> >>>> >>>>>maybe we should have a single setStrip(int flags) method and allow >>>>>various things to be stripped via flags. >>>>> >>>>>STRIP_COMMENTS - removes html comments >>>>>STRIP_REDUNDANT_WHITESPACE - compresses whitespace >>>>>STRIP_WICKET_TAGS - removes <wicket:*> tags >>>>>STRIP_WICKET_IDS - removes wicket ids entirely >>>>>STRIP_WICKET_ID_PREFIXES - removes just the wicket id prefix >>>>> >>>>>make sense? >>>>> >>>>>Juergen Donnerstag wrote: >>>>> >>>>> >>>>> >>>>>>sounds much better. Does it make sense to have two separate flags to >>>>>>enable/disable stripping. One for <wicket:....> and one for "empty" >>>>>><span id="wicket-...">? >>>>>> >>>>>>Juergen >>>>>> >>>>>> >>>>>>------------------------------------------------------- >>>>>>The SF.Net email is sponsored by: Beat the post-holiday blues >>>>>>Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. >>>>>>It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt >>>>>>_______________________________________________ >>>>>>Wicket-develop mailing list >>>>>>[email protected] >>>>>>https://lists.sourceforge.net/lists/listinfo/wicket-develop >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>------------------------------------------------------- >>>>>The SF.Net email is sponsored by: Beat the post-holiday blues >>>>>Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. >>>>>It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt >>>>>_______________________________________________ >>>>>Wicket-develop mailing list >>>>>[email protected] >>>>>https://lists.sourceforge.net/lists/listinfo/wicket-develop >>>>> >>>>> >>>>> >>>>------------------------------------------------------- >>>>The SF.Net email is sponsored by: Beat the post-holiday blues >>>>Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. >>>>It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt >>>>_______________________________________________ >>>>Wicket-develop mailing list >>>>[email protected] >>>>https://lists.sourceforge.net/lists/listinfo/wicket-develop >>>> >>>> >>>> >>>------------------------------------------------------- >>>The SF.Net email is sponsored by: Beat the post-holiday blues >>>Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. >>>It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt >>>_______________________________________________ >>>Wicket-develop mailing list >>>[email protected] >>>https://lists.sourceforge.net/lists/listinfo/wicket-develop >>> >>> >>> >> >> >> >> >>------------------------------------------------------- >>The SF.Net email is sponsored by: Beat the post-holiday blues >>Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. >>It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt >>_______________________________________________ >>Wicket-develop mailing list >>[email protected] >>https://lists.sourceforge.net/lists/listinfo/wicket-develop >> >> >> > > >------------------------------------------------------- >The SF.Net email is sponsored by: Beat the post-holiday blues >Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. >It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt >_______________________________________________ >Wicket-develop mailing list >[email protected] >https://lists.sourceforge.net/lists/listinfo/wicket-develop > ------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
