I meant dv.setcurrentpage(page); page2=dv.getcurrentpage().... -Igor
> -----Original Message----- > From: [EMAIL PROTECTED] [mailto:wicket-develop- > [EMAIL PROTECTED] On Behalf Of Igor Vaynberg > Sent: Thursday, September 22, 2005 8:55 AM > To: [email protected] > Subject: RE: [Wicket-develop] VOTE: apply patch 1288863 - forgotten > refactorings in PagingNavigator > > I really don't care for this mod. This was proposed to make gili's life > easier because he wanted an indexoutofbounds exceptions and so what he > could > then do is if (dv.setCurrentPage(page)!=page) { throw new > IndexOutOfBoundsException(); } > > But then again he can do the same thing with > Page2=dv.setCurrentPage(page); if (page2!=page) .... > > I really don't have any other usecases for this and I don't mind the extra > line of code. > > I also don't see anything that this would break in the dataview project > ... > we would still keep getCurrentPage().... > > -Igor > > > > -----Original Message----- > > From: [EMAIL PROTECTED] [mailto:wicket-develop- > > [EMAIL PROTECTED] On Behalf Of Gili > > Sent: Thursday, September 22, 2005 6:10 AM > > To: [email protected] > > Subject: Re: [Wicket-develop] VOTE: apply patch 1288863 - forgotten > > refactorings in PagingNavigator > > > > > > Yeah I know, but I'm against that paradigm. Some developers are > > already > > doing their best to stuff as much as they can into a single line of code > > and it doesn't do much for readability. Anyway, just my 2 cents. > > > > Gili > > > > Martijn Dashorst wrote: > > > Not always, command chaining is nice sometimes... Usually the add() > > > methods return void, now we on the otherhand do the same as > > > StringBuffers append: return this. > > > > > > Martijn > > > > > > On 9/22/05, Gili <[EMAIL PROTECTED]> wrote: > > > > > >> I'm -1 on this one too. Setters should have a return type of > > void. > > > > > > > > > > > > ------------------------------------------------------- > > > SF.Net email is sponsored by: > > > Tame your development challenges with Apache's Geronimo App Server. > > Download > > > it for free - -and be entered to win a 42" plasma tv or your very own > > > Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php > > > _______________________________________________ > > > Wicket-develop mailing list > > > [email protected] > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > -- > > http://www.desktopbeautifier.com/ > > > > > > ------------------------------------------------------- > > SF.Net email is sponsored by: > > Tame your development challenges with Apache's Geronimo App Server. > > Download > > it for free - -and be entered to win a 42" plasma tv or your very own > > Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php > > _______________________________________________ > > Wicket-develop mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > > ------------------------------------------------------- > SF.Net email is sponsored by: > Tame your development challenges with Apache's Geronimo App Server. > Download > it for free - -and be entered to win a 42" plasma tv or your very own > Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php > _______________________________________________ > Wicket-develop mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/wicket-develop > ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
