We just have to know if it is a full page render or a component only render i think.
We now do this:
if (this.markupStreamPosition < 0)
{
// Remember the position while rendering the component the first
// time
this.markupStreamPosition = markupStream.getCurrentIndex();
}
else
{
// Re-set the markups index to the beginning of the component tag
markupStream.setCurrentIndex(this.markupStreamPosition);
}
can't we do something like this:
if (isFullRender)
{
// Remember the position while rendering the component in a full render
this.markupStreamPosition = markupStream.getCurrentIndex();
}
else
{
// if it is a partial render set the index that was set as last in the full render.
markupStream.setCurrentIndex(this.markupStreamPosition);
}
If we do it this way then for example the bugs we had in the latest 1.1RC about loading
different kinds of markup or changes in the current markup is also not a problem.
There just has to be one full render (which should be done any way) and the position is always set
the the latest markup (if if it is changed)
johan
On 11/14/05, Juergen Donnerstag <[EMAIL PROTECTED]> wrote:
please read the previous mail about.
With 1.2 we are going to support per component re-rendering, which is
required for AJAX etc. And because the markup stream is associated
with each component, there has to be a 1:1 match between component and
tag. Actually this was always the intention. It is just that we didn't
enforce it in the past.
Juergen
On 11/14/05, Nick Heudecker <[EMAIL PROTECTED]> wrote:
> 1.2 won't allow the same wicket:id twice in the same page? This seems a bit
> arbitrary. I do this frequently and it hasn't caused any problems in 1.1.
> Why the change?
>
> ---------- Forwarded message ----------
> From: SourceForge.net <[EMAIL PROTECTED]>
> Date: Nov 14, 2005 10:56 AM
> Subject: [Wicket-develop] [ wicket-Bugs-1356696 ] OutOfMemoryError when page
> includes same wicket:id twice
> To: [EMAIL PROTECTED]
>
> Bugs item #1356696, was opened at 2005-11-14 11:56
> Message generated for change (Tracker Item Submitted) made by Item Submitter
> You can respond by visiting:
> https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1356696&group_id=119783
>
> Please note that this message will contain a full copy of the comment
> thread,
> including the initial issue submission, for this request,
> not just the latest update.
> Category: core
> Group: 1.2
> Status: Open
> Resolution: None
> Priority: 5
> Submitted By: Andrew Berman (atberman)
> Assigned to: Nobody/Anonymous (nobody)
> Summary: OutOfMemoryError when page includes same wicket:id twice
>
> Initial Comment:
> Since it is now being enforced that you cannot include
> the same wicket:id on the same page, Wicket needs to
> throw some sort of Duplicate exception. Currently, if
> you include the same wicket:id on a page (in my case a
> PagingNavigator), it yields an OutOfMemoryError.
>
> ----------------------------------------------------------------------
>
> You can respond by visiting:
> https://sourceforge.net/tracker/?func=detail&atid=684975&aid=1356696&group_id=119783
>
>
> -------------------------------------------------------
> SF.Net email is sponsored by:
> Tame your development challenges with Apache's Geronimo App Server. Download
> it for free - -and be entered to win a 42" plasma tv or your very own
> Sony(tm)PSP. Click here to play:
> http://sourceforge.net/geronimo.php
> _______________________________________________
> Wicket-develop mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/wicket-develop
>
-------------------------------------------------------
SF.Net email is sponsored by:
Tame your development challenges with Apache's Geronimo App Server. Download
it for free - -and be entered to win a 42" plasma tv or your very own
Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop
