Isn't the flag unreliable than if one component wicket:id="myLabel" is
attached to two tags? The flag will already be true prior to the
second tag being rendered? That means the information provided by this
tag is wrong during render phase of the 2nd tag?
Why do we have this flag in the first place? We call
Page.componentRendered(component) to flag a component being rendered.
If we find the component in the map maintained by the Page, it has
been rendered once.
Juergen
On 11/15/05, Johan Compagner <[EMAIL PROTECTED]> wrote:
> ha nice one :)
> We just introduced that one but it should go fine
> Because that flag is only set if i am not mistaken in the render phase.
> And in the render phase we don't support changes anymore only after the
> render phase again.
> So if we set it the with the first render it will go ok (as long as we don't
> support changes in the render phase)
>
> johan
>
>
>
> On 11/15/05, Juergen Donnerstag <[EMAIL PROTECTED]> wrote:
> >
> > Q: How are you going to handle
> >
> > /** boolean whether this component was rendered once for tracking changes.
> */
> > private static final short FLAG_IS_RENDERED_ONCE = 0x1000;
> >
> > if a single component is attached to more than one tag?
> >
> > Juergen
> >
> > On 11/15/05, Johan Compagner <[EMAIL PROTECTED]> wrote:
> > > No there is no problem currently i only said that it could been solved
> > > differently and then you
> > > had those extra checks available to you and it is just more clear.
> > >
> > > I don't mind to much about the double rendering of one component i only
> say
> > > if people want to use
> > > that and they already use that in 1.1 then we shouldn't break this
> because
> > > maybe maybe it can
> > > go wrong if they suddenly use partial rendering and the component was
> > > rendered twice with a different markup.
> > >
> > >
> > > On 11/15/05, Juergen Donnerstag < [EMAIL PROTECTED]> wrote:
> > > >
> > > > Sorry, may be I don't get it. As far as I know there currently is no
> > > > problem with reloading the markup. And I'm still not convinced that
> > > > telling users: "well sometime it does work like it but sometime it
> > > > doesn't" is the right approach.
> > > >
> > > > Juergen
> > > >
> > > >
> > > > On 11/15/05, Johan Compagner < [EMAIL PROTECTED]> wrote:
> > > > >
> > > > >
> > > > > > > And ajax partial render also works for components that are used
> > > twice.
> > > > > Only
> > > > > > > the last markupstream position is used
> > > > > >
> > > > > > How? Each component is only able to store one markup position. How
> can
> > > > > > a single component be re-rendered on two different positions?
> > > > >
> > > > >
> > > > > For ajax it doesn't matter if it was rendered in 2 positions.
> > > > > It only matter where the markup is gotten from.
> > > > > And i think 99.9% of the time when people are using this (1
> compontent
> > > > > renders twice) the exact same output will be given
> > > > > So for ajax/partial render it really doesn't matter if the markup
> comes
> > > from
> > > > > postition 123 or 321. The output is the same.
> > > > >
> > > > >
> > > > > > > And if people can live with that then they can use that if they
> want
> > > to.
> > > > > > > Fine by me
> > > > > > > And maybe for 90% of the usecases that component wouldn't even
> be
> > > used
> > > > > in
> > > > > > > partial rendering.
> > > > > > >
> > > > > >
> > > > > > IMO is bad design to tell users that in case A you can but in case
> B
> > > > > > you can not. What about application which get improved with Ajax
> > > > > > components. You than have to review you whole application. IMO a
> bad
> > > > > > idea. I still prefer it to be simple 1:1
> > > > >
> > > > >
> > > > > As i said above they can use it just perfectly. Only when the 2
> renders
> > > > > really have different markups they get different for a partial
> render
> > > > > only the last result and not the first. But i don't care about that
> > > specific
> > > > > case. because it is 0.01% if not smaller.
> > > > >
> > > > > But the isFullRender flag in my eyes is not only a solution for
> this, i
> > > had
> > > > > this idea already i though i mailed it
> > > > > when the problem of the changing markup (locale or edit of markup)
> > > because
> > > > > also in that case the isFullRender does fix that problem
> > > > >
> > > > > And i think the error reporting can impore because now you also can
> do:
> > > > >
> > > > > if(fullRender)
> > > > > {
> > > > > markuppos = stream.getMarkupPos ()
> > > > > }
> > > > > else if(markuppos < 0)
> > > > > {
> > > > > throw exception("No full render yet")
> > > > > }
> > > > > else
> > > > > {
> > > > > stream.setMarkupPos()
> > > > > }
> > > > >
> > > > > And that in conjuction with the fixes of changing markup we can
> handle
> > > it
> > > > > more gracefully.
> > > > >
> > > > >
> > > > > johan
> > > > >
> > > > >
> > > > >
> > > >
> > > >
> > > >
> -------------------------------------------------------
> > > > This SF.Net email is sponsored by the JBoss Inc. Get Certified Today
> > > > Register for a JBoss Training Course. Free Certification Exam
> > > > for All Training Attendees Through End of 2005. For more info visit:
> > > > http://ads.osdn.com/?ad_idv28&alloc_id845&opclick
> > > > _______________________________________________
> > > > Wicket-develop mailing list
> > > > [email protected]
> > > >
> > >
> https://lists.sourceforge.net/lists/listinfo/wicket-develop
> > > >
> > >
> > >
> >
> >
> > -------------------------------------------------------
> > This SF.Net email is sponsored by the JBoss Inc. Get Certified Today
> > Register for a JBoss Training Course. Free Certification Exam
> > for All Training Attendees Through End of 2005. For more info visit:
> > http://ads.osdn.com/?ad_idv28&alloc_id845&opclick
> > _______________________________________________
> > Wicket-develop mailing list
> > [email protected]
> >
> https://lists.sourceforge.net/lists/listinfo/wicket-develop
> >
>
>
-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc. Get Certified Today
Register for a JBoss Training Course. Free Certification Exam
for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_idv28&alloc_id845&op=click
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop
