Johan Compagner wrote:
this piece of code is also not finished yet?

WebRequestEncoder
protected final String encode(RequestCycle requestCycle, IPageClassRequestTarget requestTarget)
    {
        final Class pageClass = requestTarget.getPageClass ();
final PageParameters parameters = requestTarget.getPageParameters();
        final StringBuffer url = urlPrefix(requestCycle);
        url.append("?bookmarkablePage=");
        String pageReference = pageClass.getName();
        if (pageReference == null)
        {
            pageReference = pageClass.getName();
        }
        url.append(pageReference);

??

The if (pageReference == null) is ofcourse very sttrange because in the if and outside the if we do the same thing...
And now again the full classname is in the url.
That is for quite a few persons i know not acceptable (thats why we had the page aliasses!!) You don't want to expose any internals from youre web application like package names and or full classnames.

Is there now some possibility to "mount" an page class on a string?

johan
It would also help a lot when urlrewriting the beautiful urls if the parameters would be always in same order. Alphabetical or something else, but something predictable. This could be achieved by using TreeMap instead of HashMap in PageParameters (=ValueMap).

But could the parameters of the bookmarkablePage be something smarter (and more beautiful?)


Janne


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop

Reply via email to