One usage is like i said in IAuthorizationStrategy. Most of the time you want errorpages to always be able to be constructed. Ofcourse if you are using jaas you can also put them in your policy, but having a tagging interface for different types of pages (in this case errorpages) is always a good idea. And if we use a tagging interface we can indeed remove the isErrorPage method. just my thoughts.
Maurice 2005/11/29, Johan Compagner <[EMAIL PROTECTED]>: > i see we only do it the Class check way we already had and that is fine by > me > (so currentResponsePage != internal or exceptionpage then respond else send > servlet error) > > > Now the question remains where do you need info that it is a error page. > Because it is just wickets own pages or the one the developer itself says it > is (InternalError page) > > johan > > > > On 11/29/05, Johan Compagner < [EMAIL PROTECTED]> wrote: > > Page.isErrorPage () isn't called anymore no > > But how do we catch it now when a page that was the error page is > failing?? > > > > > > johan > > > > > > > > On 11/29/05, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > > > dont know, havent had the time to go through all the changes yet. > > > -Igor > > > > > > > > > > > > > > > On 11/29/05, Eelco Hillenius < [EMAIL PROTECTED]> wrote: > > > > Actually, I don't think we need such a method nor a tagging interface > > > > at all after the refactorings? > > > > > > > > Eelco > > > > > > > > > > > > On 11/29/05, Johan Compagner <[EMAIL PROTECTED] > wrote: > > > > > i agree and i also find that a much better approache > > > > > especially because you can check the class instead of an instance of > it. > > > > > > > > > > johan > > > > > > > > > > > > > > > > > > > > On 11/29/05, Igor Vaynberg < [EMAIL PROTECTED] > wrote: > > > > > > if we create a tagging interface there is no longer a need for > > > > > iserrorpage() > > > > > > > > > > > > -Igor > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 11/29/05, Maurice Marrink < [EMAIL PROTECTED]> wrote: > > > > > > > I know Page has an isErrorPage method to identify errorpages > from > > > > > > > normal pages, but if you only have the classname of the page > (for > > > > > > > example in > > > > > IAuthorizationStrategy.allowCreateComponent(Class > clz)) > > > > > > > that is not enough. > > > > > > > Therefore i would like to suggest a tagging interface (say > ErrorPage) > > > > > > > that all pages the return true for isErrorPage should implement. > So we > > > > > > > can easilly distinct between the different pagetypes. > > > > > > > > > > > > > > Maurice > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------- > > > > > > > This SF.net email is sponsored by: Splunk Inc. Do you grep > through log > > > > > files > > > > > > > for problems? Stop! Download the new AJAX search engine that > makes > > > > > > > searching your log files as easy as surfing the web. DOWNLOAD > SPLUNK! > > > > > > > > http://ads.osdn.com/?ad_idv37&alloc_id865&opclick > > > > > > > _______________________________________________ > > > > > > > Wicket-develop mailing list > > > > > > > [email protected] > > > > > > > > > > > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > ------------------------------------------------------- > > > > This SF.net email is sponsored by: Splunk Inc. Do you grep through log > files > > > > for problems? Stop! Download the new AJAX search engine that makes > > > > searching your log files as easy as surfing the web. DOWNLOAD > SPLUNK! > > > > http://ads.osdn.com/?ad_idv37&alloc_id865&opclick > > > > _______________________________________________ > > > > Wicket-develop mailing list > > > > [email protected] > > > > > https://lists.sourceforge.net/lists/listinfo/wicket-develop > > > > > > > > > > > > > > > > ------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Do you grep through log files for problems? Stop! Download the new AJAX search engine that makes searching your log files as easy as surfing the web. DOWNLOAD SPLUNK! http://ads.osdn.com/?ad_idv37&alloc_id865&op=click _______________________________________________ Wicket-develop mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-develop
