-Igor
On 12/18/05, Johan Compagner <[EMAIL PROTECTED]> wrote:
removing that method will break a lot of apps i think
Many people are using it.
handling an exception is for me an application issue. So to say that i find that in the wrong place.. don't think so.
johan
On 12/18/05, Eelco Hillenius <[EMAIL PROTECTED] > wrote:I'll work on a new proposal now.
Eelco
On 12/18/05, Eelco Hillenius <[EMAIL PROTECTED] > wrote:
> But why 'just handling exceptions'. It is quite a non-standard thing
> you are trying to do. Furthermore, there is
> WebApplication.getDefaultRequestCycleFactory so it is not that much
> work.
>
> But like I said, I am not in favor of having such a method in the first place as
>
> protected Page onRuntimeException(final Page page, final RuntimeException e)
>
> gives you crappy info. There doesn't even need to be a page; it should
> be request target in the current state, which could mean anything from
> a page to a shared resource to an external resource. Furthermore, the
> only thing you should allow this method to do is to use the request
> processing strategy. If we don't do this, we can't even guarantee the
> contract of that strategy. And finally, the application scope just
> sucks. We can put everything in the semi-global application scope,
> can't we? That's allways the easiest solution, but is not very object
> oriented. Finally, we shouldn't be too uptight about having a few
> lines more if that makes sense for something you do once in your
> project/ application if people use it at all.
>
> Eelco
>
>
> On 12/18/05, Johan Compagner <[EMAIL PROTECTED]> wrote:
> > Don't move it to the request cycle !
> > There it was really at the beginning. But that is just horrible because what
> > is needed to be done before you can override an request cycle....
> >
> > Application.getSessionFactory().newSession().getRequestCycleFactory().newRequestCycle()
> >
> > So you have to make 4 classes to have youre own request cycle. That is
> > horrible for just handling exceptions.
> >
> > johan
> >
> >
> >
> > On 12/18/05, Eelco Hillenius < [EMAIL PROTECTED] > wrote:
> > >
> > > I'm not to happy to have a method like that in the Application object
> > > in the first place. First of all, as you can replace the request
> > > processing strategy, it is in fact not really needed, but mere
> > > convenience. And as a convenience method, I think it would make much
> > > more sense to have that (still overridable) method part of the request
> > > cycle. Imo, the scoping would be more logical. But really, I'm still
> > > thinking about whether we should provide such a convenience method in
> > > the first place.
> > >
> > > Eelco
> > >
> > >
> > > On 12/18/05, Igor Vaynberg < [EMAIL PROTECTED]> wrote:
> > > > hi guys, looks like our latest request cycle refactoring broke
> > > > onRuntimeException handler in Application. i looked into fixing it and
> > there
> > > > doesnt seem to be a very clean way.
> > > >
> > > > first, we no longer deal with a runtime exception, our
> > > > IExceptionResponseStrategy now deals with a regular exception. so i
> > renamed
> > > > onRuntimeException to onException and it now takes a regular exception
> > as a
> > > > param.
> > > >
> > > > secondly it is now public since the response strategy and application
> > are
> > > > no longer in the same package.
> > > >
> > > > finally there is also some weirdness in mock application since you cant
> > > > rethrow a checked exception without declaring it so i have to wrap it in
> > a
> > > > runtime exception which is not what user might expect.
> > > >
> > > > im attaching the patch. if no one is against this fix i will commit it.
> > > > just wanted to check since this will break some clients.
> > > >
> > > > -Igor
> > > >
> > > >
> > > >
> > >
> > >
> > > -------------------------------------------------------
> > > This SF.net email is sponsored by: Splunk Inc. Do you grep through log
> > files
> > > for problems? Stop! Download the new AJAX search engine that makes
> > > searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
> > > http://ads.osdn.com/?ad_idv37&alloc_id865&opclick
> > > _______________________________________________
> > > Wicket-develop mailing list
> > > [email protected]
> > >
> > https://lists.sourceforge.net/lists/listinfo/wicket-develop
> > >
> >
> >
>
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_idv37&alloc_id865&opclick
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop
