What about renaming doRender() (Page and Component) instead of
renaming render(). Page.doRender is an internal API that is true and
Component.doRender is not meant to be internal but they serve the same
purpose: render a component (which ever Wicket component) from
"outside" (target, ajax handler, ...) and both implementations main
purpose is to make sure that everything is set-up that the component
can be properly rendered. In that sense Page.doRender overrides
Component.doRender as the logic to prepare to render a Page is
different.

Or to get rid of doRender completely (Component and Page) try to move
Page.doRender into Page.render() and Component.doRender into
Component.render.



On 1/15/06, Jonathan Locke <[EMAIL PROTECTED]> wrote:
>
> the other thing is that Component.render() is already being used
> publicly in places like ListView...
>
>     protected void renderItem(final ListItem item)
>     {
>         item.render();
>     }
>
> Juergen Donnerstag wrote:
> > Page.doRender is used from the target to render a Page.
> > Component.doRender is called from the target to re-render a component.
> > Why is it more logial to call Page.doRender for pages and
> > Component.render for components? IMO render() is completely internal
> > and should not be used by anyone. That is true for Page.render and
> > Component.render as well. From that point of view it wouldn't make
> > sense to make Component.render more intelligent.
> >
> > Juergen
> >
> >
> > On 1/15/06, Jonathan Locke <[EMAIL PROTECTED]> wrote:
> >
> >> can't the logic for doRender() just be folded into a smarter render()
> >> method?
> >> and then ajaxhandler could expose a render() method which would do the most
> >> appropriate thing to render the component that the handler is attached 
> >> to...
> >>
> >> Jonathan Locke wrote:
> >>
> >>> i'm okay with manual rendering so long as it's not through a method
> >>> called doRender(),
> >>> which sounds internal and does not differentiate itself from render().
> >>>
> >>>> Let the conclusion be that things are fine as they are now. If people
> >>>> want to be consistent with how our request cycle works, they should
> >>>> use request targets. If people want a more direct way, they render
> >>>> manually. Especially in the case of AJAX, I think there is nothing
> >>>> wrong with either.
> >>>>
> >>>>
> >>>> Eelco
> >>>>
> >>>>
> >>>> -------------------------------------------------------
> >>>> This SF.net email is sponsored by: Splunk Inc. Do you grep through
> >>>> log files
> >>>> for problems?  Stop!  Download the new AJAX search engine that makes
> >>>> searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> >>>> http://ads.osdn.com/?ad_idv37&alloc_id865&opÌk
> >>>> _______________________________________________
> >>>> Wicket-develop mailing list
> >>>> [email protected]
> >>>> https://lists.sourceforge.net/lists/listinfo/wicket-develop
> >>>>
> >>>>
> >>>>
> >>> -------------------------------------------------------
> >>> This SF.net email is sponsored by: Splunk Inc. Do you grep through log
> >>> files
> >>> for problems?  Stop!  Download the new AJAX search engine that makes
> >>> searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> >>> http://ads.osdn.com/?ad_idv37&alloc_id865&opÌk
> >>> _______________________________________________
> >>> Wicket-develop mailing list
> >>> [email protected]
> >>> https://lists.sourceforge.net/lists/listinfo/wicket-develop
> >>>
> >>>
> >> -------------------------------------------------------
> >> This SF.net email is sponsored by: Splunk Inc. Do you grep through log 
> >> files
> >> for problems?  Stop!  Download the new AJAX search engine that makes
> >> searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> >> http://ads.osdn.com/?ad_idv37&alloc_id865&opclick
> >> _______________________________________________
> >> Wicket-develop mailing list
> >> [email protected]
> >> https://lists.sourceforge.net/lists/listinfo/wicket-develop
> >>
> >>
> >
> >
> > -------------------------------------------------------
> > This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
> > for problems?  Stop!  Download the new AJAX search engine that makes
> > searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> > http://ads.osdn.com/?ad_idv37&alloc_id865&opÌk
> > _______________________________________________
> > Wicket-develop mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/wicket-develop
> >
> >
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
> for problems?  Stop!  Download the new AJAX search engine that makes
> searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
> http://ads.osdn.com/?ad_idv37&alloc_id865&opclick
> _______________________________________________
> Wicket-develop mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/wicket-develop
>


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_idv37&alloc_id865&op=click
_______________________________________________
Wicket-develop mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-develop

Reply via email to