The only thing that I don't really like is that I have to override
add/remove/removeall to get the ordering working - I think there should be a
template listener method that you can override like onChildAdded and
onChildRemoved.

For example currently autoAdd() calls add() internally so I don't override
it because that would add the component to the order twice - but is this a
clearly defined contract?

Also remove() doesn't get called when removeall() is called so I have to
override that also.

Do the two afore mentioned listeners make sense? Should I submit a patch?
That way I can just override onchildadded and onchildremoved w/out
overriding add/remove/removeall and the contract would be more clear.

-Igor


> -----Original Message-----
> From: [EMAIL PROTECTED] 
> [mailto:[EMAIL PROTECTED] On Behalf Of 
> Phil Kulak
> Sent: Thursday, August 11, 2005 3:41 PM
> To: [email protected]
> Subject: Re: [Wicket-user] DataView: IDataProvider.primaryKey() vote
> 
> Good job, Igor. I like the changes a lot.
> 
> On 8/11/05, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
> > Just checked in a bunch of changes. Check them out and lets discuss.
> > 
> > Here is the gist:
> > Added RepeatingView which simply renders all its children in no 
> > particular order - DataView no longer contains onRender() Added 
> > OrderedRepeatingView extends RepeatingView this renders its 
> children 
> > in the order they were added.
> > DataView now extends OrderedRepeatingView and 
> onBeginRequest has been 
> > reworked to work with or without a IUniqueKeyProvider.
> > 
> > -Igor
> > 
> > 
> > > -----Original Message-----
> > > From: [EMAIL PROTECTED]
> > > [mailto:[EMAIL PROTECTED] On Behalf Of 
> > > Christian Essl
> > > Sent: Thursday, August 11, 2005 12:56 PM
> > > To: [email protected]
> > > Subject: Re: [Wicket-user] DataView: 
> IDataProvider.primaryKey() vote
> > >
> > > On Thu, 11 Aug 2005 08:20:06 -0700, Igor Vaynberg 
> > > <[EMAIL PROTECTED]>
> > > wrote:
> > >
> > > >> -----Original Message-----
> > > >> From: [EMAIL PROTECTED]
> > > >> [mailto:[EMAIL PROTECTED] On Behalf Of 
> > > >> Christian Essl
> > >
> > > > Equals() wont work because that wont be able to handle two
> > > of the same
> > > > object in the iterator.
> > > Good point. You mean in your case of primaryKey an Exception is 
> > > always thrown, because of the component-id check in the container 
> > > and in my case not. Good catch this is a bug - thanks. 
> The bug could 
> > > either be solved by also throwing an Exception or by doing what I 
> > > think the user rather expects, namely showing all Objects in the 
> > > iterator (wheter double contained or not) and than making 
> sure that 
> > > on the next turn the DataItems which share an equal IModel are 
> > > always removed and potentially recreated.
> > > I acutally think the second solution can be implemented with very 
> > > little performance loss.
> > >
> > > > I think the solution would be pretty simple: if you 
> want optimized 
> > > > item removal you need to provide the primarykey - maybe 
> we can add 
> > > > some stuff to primarykey() params to make it easier.
> > > >
> > > I am not so keen on optimized item removal. I was more against a 
> > > mandatory
> > > primaryKey() mehtod. Than I got tracked into showing that 
> it is not 
> > > needed.
> > >
> > > I know you are short on time so thanks for the rather long 
> > > discussion, Christian
> > >
> > >
> > >
> > >
> > >
> > > ___________________________________________________________
> > > Gesendet von Yahoo! Mail - Jetzt mit 1GB Speicher 
> kostenlos - Hier 
> > > anmelden: http://mail.yahoo.de
> > >
> > >
> > >
> > > -------------------------------------------------------
> > > SF.Net email is Sponsored by the Better Software 
> Conference & EXPO 
> > > September 19-22, 2005 * San Francisco, CA * Development Lifecycle 
> > > Practices Agile & Plan-Driven Development * Managing Projects & 
> > > Teams * Testing & QA Security * Process Improvement & 
> Measurement * 
> > > http://www.sqe.com/bsce5sf 
> > > _______________________________________________
> > > Wicket-user mailing list
> > > [email protected]
> > > https://lists.sourceforge.net/lists/listinfo/wicket-user
> > >
> > >
> > >
> > 
> > 
> > 
> > 
> > -------------------------------------------------------
> > SF.Net email is Sponsored by the Better Software Conference & EXPO 
> > September 19-22, 2005 * San Francisco, CA * Development Lifecycle 
> > Practices Agile & Plan-Driven Development * Managing 
> Projects & Teams 
> > * Testing & QA Security * Process Improvement & Measurement * 
> > http://www.sqe.com/bsce5sf 
> > _______________________________________________
> > Wicket-user mailing list
> > [email protected]
> > https://lists.sourceforge.net/lists/listinfo/wicket-user
> >
> 
> 
> -------------------------------------------------------
> SF.Net email is Sponsored by the Better Software Conference & 
> EXPO September 19-22, 2005 * San Francisco, CA * Development 
> Lifecycle Practices Agile & Plan-Driven Development * 
> Managing Projects & Teams * Testing & QA Security * Process 
> Improvement & Measurement * http://www.sqe.com/bsce5sf 
> _______________________________________________
> Wicket-user mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/wicket-user
> 
> 
> 




-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-user

Reply via email to