I do not know about ListView, but I think DataView and PagableDataView could be merged quite easaly.

It already has the data-set size and the rows-count per page. All we would need is to add a currentPage property and than we just render from the startIndex+offsetOfPage.

On bounding: I think we should strictly adhear to the navigator for the current page property. If DataView is instructed to show ie page 7 and there is nothing anymore on page 7 than it should just show nothing. The navigator should deal with that, it is the one who shows the current page-label. Especially DataView should not do any more bounding than Math.max(0,settedPage). That is because you can realy get some nasty bugs if a property value is set, than internally changed in the setMethod and than not afterwards reread. Alternatively we should at least throw an IndexOutOfBoundsEx.

I think I'll (try to) implement Igor's Grid example as a Component after the IPageable is stable and DataView/PagabelDataView implements it. I guess before this it is just redundant work and there is the example which does with just one copy-paste the job very well.

Christian

On Fri, 19 Aug 2005 09:28:27 -0700, Igor Vaynberg <[EMAIL PROTECTED]> wrote:

I really like the idea of having a listview that shows everything by
default, and when you attach a pager to it it becomes pageable. So something
like irangepageable { getrowsperpage() setrowsperpage() getmaxrows() }But
that's just me.

Btw whats getmaxrows() is that getrowcount()?

I don't see why the listview cannot have setrowsperpage() anyways which
defaults to showing everything until used.

-Igor


-----Original Message-----
From: [EMAIL PROTECTED]
[mailto:[EMAIL PROTECTED] On Behalf Of
Johan Compagner
Sent: Friday, August 19, 2005 2:29 AM
To: [email protected]
Subject: Re: [Wicket-user] Re: ColumnedDataProvider
startIndex problems


>
>> Alternatively we should make an PageableOrderedRepeatingView.
>>
>
> I want to wait for the new navigation to be done so we
don't need to
> have the regular - pageable pairs.
>
>

I am currently inclined to keep this difference.

Because now i have

IPageable
{
    getCurrentPage();
    setCurrentPage(int);
    getPageCount();
}

and i think i will make this one:

IRangePageable extends IPageable
{
    getRowsPerPage();
    getMaxRows();
}

instead of

IRangePageable extends IPageable
{
    setRowsPerPage(int);
    getMaxRows();
}

i think setting the number of rows a page should display is a
property of the View that displays them Not something of the
Navigation/Navigator that is attached to it..

But if others are more in for pushing the rows per page
instead of pulling then i could change my mind.

and ListView doesn't have to be a RangePageable it could also
be used to display a panel and that it is only a Pageable So
giving a listview by default the RangePageable interface is
also wrong.
ListView could be directly an IPageable and PageableListView
an IRangePageable.

looks that logical?

johan


johan



-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference &
EXPO September 19-22, 2005 * San Francisco, CA * Development
Lifecycle Practices Agile & Plan-Driven Development *
Managing Projects & Teams * Testing & QA Security * Process
Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-user







-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-user



--
Christian Essl
        

        
                
___________________________________________________________ Gesendet von Yahoo! Mail - Jetzt mit 1GB Speicher kostenlos - Hier anmelden: http://mail.yahoo.de



-------------------------------------------------------
SF.Net email is Sponsored by the Better Software Conference & EXPO
September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices
Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA
Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf
_______________________________________________
Wicket-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/wicket-user

Reply via email to