I did the changes necessary to not render invisible component and it passes all existing unit tests. Any more suggestions (votes) on this topic?
Juergen On 8/24/05, Johan Compagner <[EMAIL PROTECTED]> wrote: > if i had to choose then don't render at all if not visible > A developer will also test the component if it is visible so it will get > that error then. > Not visible. Is just not there. If even the markup/component don't apply > that can happen > And it could be that this is even a thing i want?? > > I have a page with markup. > But in one condition i don't want to render quite a large part. of it. > Then i could build up all the components > Or just insert one empty markupcontainer that has no childs but is just > invisible.. > > I like that.. It even shaves of page sizes. > But ofcourse we can have a choice for this on app settings. > > johan > > > Juergen Donnerstag wrote: > > we could do, it seems not to be a large change, but ... > > Currently users (designers and developers) can be sure that wicket > > throws an exception if there not a 1:1 mapping between all wicket tag > > (wicket:id and <wicket:) defined and components added. No suprises at > > runtime at all. This check can be disabled by appSettings.setXX, but > > than it is the users choice. > > If we decide to change it, there no such guarantee anymore, as it > > depends on the components visibility as well. E.g. provided your test > > users or automated tests don't cover a specific use case where a > > component's visibility is enabled, than all by a sudden, end user will > > get an exception. I personally like the strictness as it avoid errors, > > but I understand your use case. Any suggestion on how we can achieve > > both? Shall we introduce a new booelan value for apps setting? How > > shall we name it? > > > > Juergen > > > > > > On 8/23/05, Johan Compagner <[EMAIL PROTECTED]> wrote: > > > >> ehmm it does get renderd.. Only the output doesn't get streamed (all > >> rendering goes to a null output) > >> > >> I think we do that so that the markup advances correctly (the current > >> pointer) > >> We should be able to skip a markup and set the markup stream correctly > >> after the component that was not visible > >> > >> But that is more a juergen kind of thing... > >> > >> johan > >> > >> > >> Eelco Hillenius wrote: > >> > >>> Yep. Also, I should do any model updates when it is part of a form, > >>> and it should not be reachable as a listener too, though I think that > >>> still is an open issue. > >>> > >>> Eelco > >>> > >>> On 8/23/05, Anders Peterson <[EMAIL PROTECTED]> wrote: > >>> > >>> > >>>> Hi, > >>>> > >>>> If I set a component to not visible "setVisible(false)" then that > >>>> component and any/all children should not get rendered - right? > >>>> > >>>> Just like confirmation before I submit a bug report. > >>>> > >>>> /Anders > >>>> -- > >>>> http://ojalgo.org/ > >>>> > >>>> Mathematics, Linear Algebra and Optimisation with Java > >>>> > >>>> > >>>> > >>>> ------------------------------------------------------- > >>>> SF.Net email is Sponsored by the Better Software Conference & EXPO > >>>> September 19-22, 2005 * San Francisco, CA * Development Lifecycle > >>>> Practices > >>>> Agile & Plan-Driven Development * Managing Projects & Teams * Testing & > >>>> QA > >>>> Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf > >>>> _______________________________________________ > >>>> Wicket-user mailing list > >>>> [email protected] > >>>> https://lists.sourceforge.net/lists/listinfo/wicket-user > >>>> > >>>> > >>>> > >>> ------------------------------------------------------- > >>> SF.Net email is Sponsored by the Better Software Conference & EXPO > >>> September 19-22, 2005 * San Francisco, CA * Development Lifecycle > >>> Practices > >>> Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA > >>> Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf > >>> _______________________________________________ > >>> Wicket-user mailing list > >>> [email protected] > >>> https://lists.sourceforge.net/lists/listinfo/wicket-user > >>> > >>> > >>> > >> ------------------------------------------------------- > >> SF.Net email is Sponsored by the Better Software Conference & EXPO > >> September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices > >> Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA > >> Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf > >> _______________________________________________ > >> Wicket-user mailing list > >> [email protected] > >> https://lists.sourceforge.net/lists/listinfo/wicket-user > >> > >> > > > > > > ------------------------------------------------------- > > SF.Net email is Sponsored by the Better Software Conference & EXPO > > September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices > > Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA > > Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf > > _______________________________________________ > > Wicket-user mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > ------------------------------------------------------- > SF.Net email is Sponsored by the Better Software Conference & EXPO > September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices > Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA > Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf > _______________________________________________ > Wicket-user mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/wicket-user > ------------------------------------------------------- SF.Net email is Sponsored by the Better Software Conference & EXPO September 19-22, 2005 * San Francisco, CA * Development Lifecycle Practices Agile & Plan-Driven Development * Managing Projects & Teams * Testing & QA Security * Process Improvement & Measurement * http://www.sqe.com/bsce5sf _______________________________________________ Wicket-user mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wicket-user
