I removed that. What's the point of checking whether it's one of the available message levels, when that is something users might decide to tweak themselves? I don't see any potential mis-use comming from that which would make Wicket harder to maintain or users digging their own holes to fall in.
Eelco On 5/3/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote:
since you are the one who losened it up, do you mind adding some defensive code into the constructor? :) -Igor On 5/3/06, Eelco Hillenius < [EMAIL PROTECTED]> wrote: > Ok, I loosened it up a bit. > > Eelco > > > On 5/3/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > Well, as already written I'm using a custom feedback messages model to be able to mix in static messages: > > > > >protected FeedbackMessagesModel newFeedbackMessagesModel() { > > > return new FeedbackMessagesModel(newFilter()) { > > > protected List processMessages(List messages) { > > > messages.addAll(getStaticMessages()); > > > return messages; > > > } > > > }; > > >} > > > > The following comment in FeedbackMessagesModel suggests such usage (emphasis mine): > > > > // Let subclass do any extra processing it wants to on the messages. > > // It may want to do something special, such as removing a given > > // message under some special condition or perhaps eliminate > > // duplicate messages. It could even *add a message under certain > > // conditions*. > > > > In getStaticMessages() I want to create a FeedbackMessage via its (hopefully) public constructor. > > > > Regretfully there seems to be no other way to something similar. Adding messages in onBeginRequest() to a componentn (which I would have preferred) is too late, as already discussed on this list. > > > > Sven > > > > ------------------------------ > > > > whoops, looks like i didnt clean up as well as i thought i did. sessionStored stuff is now all gone. > > > > what exactly is your usecase that you have to create feedbackmessage objects yourself? why not call any of the given info/warn/whatever methods on a component or session? > > > > -Igor > > > > > > > > On 5/2/06, Sven Meier <[EMAIL PROTECTED]> wrote:Thanks, but one additional thing: > > > > To be able to mix in some special messages, I want to construct > > FeedbackMessages on my own. > > But the FeedbackMessage constructor is package protected :(. > > > > Any chance that the modifier could be changed to public? > > > > BTW what's the 'sessionStored' property meant for - I didn't find a > > reference to it and it's a little bit odd as a constructor argument. > > > > Sven > > > > Eelco Hillenius wrote: > > > > >Done. > > > > > >Eelco > > > > > > > > >On 4/28/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > > > > > > > >>I want to override FeedbackMessagesModel.processMessages () to be able to add special messages. This seems to be one of its intended usages according to the javadoc. > > >> > > >>Regretfully FeedbackMessagesModel is final, so could this modifier please be removed? > > >> > > >>Thanks > > >> > > >>Sven > > >> > > >> > > >>------------------------------------------------------- > > >>Using Tomcat but need to do more? Need to support web services, security? > > >>Get stuff done quickly with pre-integrated technology to make your job easier > > >>Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > > >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > >>_______________________________________________ > > >>Wicket-user mailing list > > >> Wicket-user@lists.sourceforge.net > > >>https://lists.sourceforge.net/lists/listinfo/wicket-user > > >> > > >> > > >> > > > > > > > > >------------------------------------------------------- > > >Using Tomcat but need to do more? Need to support web services, security? > > >Get stuff done quickly with pre-integrated technology to make your job easier > > >Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > > >http://sel.as-us.falkag.net/sel?cmd=k&kid0709&bid&3057&dat1642 > > >_______________________________________________ > > >Wicket-user mailing list > > >Wicket-user@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > > > > > > > > > > > ------------------------------------------------------- > > Using Tomcat but need to do more? Need to support web services, security? > > Get stuff done quickly with pre-integrated technology to make your job easier > > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > > _______________________________________________ > > Wicket-user mailing list > > Wicket-user@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > ------------------------------------------------------- > > Using Tomcat but need to do more? Need to support web services, security? > > Get stuff done quickly with pre-integrated technology to make your job easier > > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > > http://sel.as-us.falkag.net/sel?cmdlnk&kid0709&bid&3057&dat1642 > > _______________________________________________ > > Wicket-user mailing list > > Wicket-user@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > ------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmdlnk&kid0709&bid&3057&dat1642 > _______________________________________________ > Wicket-user mailing list > Wicket-user@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wicket-user >
------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid0709&bid&3057&dat1642 _______________________________________________ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user