I think the current method name makes sense, but what is unclear is whether the CURRENT page is taking up one of the positions. I would think setting the max to 1 would ensure that the pagemap contains the current page and no others. If in fact the current page doesn't need room in the page map, then I guess 0 would make more sense. I think adding detail to the javadoc should be sufficient to clear up this ambiguity.
Johan Compagner wrote: > > set the max to 0 then the change list of the version manager will really > not > contain anything > > this is the test: (after the new one is added to the list) > > // If stack is overfull, remove oldest entry > if (getVersions() > maxVersions) > { > expireOldestVersion(); > } > > What is logical? max versions is that also counting the current one? > What is the best English for this?? > should we better express it like: setMaxPageUndoBuffer() ?? > > johan > > > On 1/24/07, dukejansen <[EMAIL PROTECTED]> wrote: >> >> >> >> Eelco Hillenius wrote: >> > >> > Well, every user (session) will use memory, correct. But only to a >> > certain limit. Wicket 1.2 holds a couple of page/ versions in a >> > session, and Wicket 2.0 by default only holds the current one. So the >> > creation of a fresh instance (e.g. a bookmarkable page) will replace >> > another one. Hence, how much memory you'll need is a simple function >> > of the number of concurrent sessions times the size of your session >> > and page(s) in it. >> > >> >> How can I instruct Wicket not to maintain the multiple versions of a >> given >> page within the session? I've tried the following but when I dump the >> session contents I still see multiple page versions: >> >> getSessionSettings().setMaxPageMaps(1); >> getPageSettings().setMaxPageVersions(1); >> >> Am I missing the boat on this entirely? >> >> -Jason >> -- >> View this message in context: >> http://www.nabble.com/Strategy-to-avoid-new-instances-of-pages-and-panels-tf2566413.html#a8553452 >> Sent from the Wicket - User mailing list archive at Nabble.com. >> >> >> ------------------------------------------------------------------------- >> Take Surveys. Earn Cash. Influence the Future of IT >> Join SourceForge.net's Techsay panel and you'll get the chance to share >> your >> opinions on IT & business topics through brief surveys - and earn cash >> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV >> _______________________________________________ >> Wicket-user mailing list >> Wicket-user@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/wicket-user >> > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share > your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Wicket-user mailing list > Wicket-user@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wicket-user > > -- View this message in context: http://www.nabble.com/Strategy-to-avoid-new-instances-of-pages-and-panels-tf2566413.html#a8570594 Sent from the Wicket - User mailing list archive at Nabble.com. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user