see my comment on: https://issues.apache.org/jira/browse/WICKET-400
i think we should change the RequestParamters.getParamters()
don't return a map there but return a ValueMap so that we shield it that it
could be request parameters directly (with things from use added)
then they can call directly what the want (like getString or getInt) and we
do the converstion String[] -> string/int and so on there
johan
On 5/15/07, Johan Compagner <[EMAIL PROTECTED]> wrote:
we do add internally some things i thing that we later on need, i
thinkg this is commented in the code. maybe we could move that to
RequestParameters itself? We should try to abstract everything in that
class so that people dont have to use it directly?
On 5/15/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> > i am not saying we shouldntve fixed it to return an array always, what
i
> am
> > saying is that it is inconsistent because when we put things into that
map
> > we dont wrap them in an array, and we should, no?
>
> I don't know whether we should. Those are parameters we ourselves
> added, so however we'd add them, it wouldn't lead to inconsistencies
> with the servlet request parameters other than that the servlet API
> returns an immutable map to start with.
>
> > why is that map mutable?
>
> I think that's in the commit comments somewhere. If I remember
> correctly, I wanted to make it immutable, but other parts broke. Note
> that it's a copy btw.
>
> Eelco
>
>
-------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> Wicket-user mailing list
> Wicket-user@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wicket-user
>
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Wicket-user mailing list
Wicket-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-user
