Ok, thanks. :) I've pushed some more changes now. Some comments: If we have a check as part of the stylechecker for this, then I think someone should check whether that still works and is run.
How can logic/building.cc:686 ever be called when the if has the same check as the while loop above? The cppcheck report also listed logic/tribe.cc:233, but that section looks a bit special and I'm not sure what's going on there, so I left it alone... -- https://code.launchpad.net/~hjd/widelands/optimizations/+merge/101116 Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/optimizations into lp:widelands. _______________________________________________ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
