Replied to a diff comment. Diff comments:
> > === modified file 'src/map_io/map_players_view_packet.cc' > --- src/map_io/map_players_view_packet.cc 2016-02-16 10:27:23 +0000 > +++ src/map_io/map_players_view_packet.cc 2016-05-01 10:05:57 +0000 > @@ -991,12 +991,12 @@ > } > > // edges > - if (!bl_seen & (f_everseen | > bl_everseen)) > + if (!(bl_seen) & (f_everseen | > bl_everseen)) > > roads_file.unsigned_8(f_player_field.road_sw()); > - if (!br_seen & (f_everseen | > br_everseen)) > + if (!(br_seen) & (f_everseen | > br_everseen)) > > roads_file.unsigned_8(f_player_field.road_se()); > - if (!r_seen & (f_everseen | > r_everseen)) > - > roads_file.unsigned_8(f_player_field.road_e ()); > + if (!(r_seen) & (f_everseen | > r_everseen)) > + > roads_file.unsigned_8(f_player_field.road_e()); Care to elaborate on why using logical operations here would change semantics? Bools can only hold 0 or 1, and all of the operand variables are bools, so the results should be the same for both bitwise and logical operations. > } > > // geologic survey -- https://code.launchpad.net/~widelands-dev/widelands/gcc531/+merge/293478 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/gcc531. _______________________________________________ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
