Review: Approve
look at me! I did a codereview!!!
code lgtm. only one nit.
Diff comments:
>
> === modified file 'src/wui/mapdata.cc'
> --- src/wui/mapdata.cc 2016-04-16 07:10:03 +0000
> +++ src/wui/mapdata.cc 2016-05-17 07:53:34 +0000
> @@ -131,11 +131,20 @@
> }
>
> // static
> +MapData MapData::create_empty_dir(const std::string& current_dir) {
> + /** TRANSLATORS: Empty current folder */
this translator comment is pretty cryptic.
> + return MapData(current_dir, (boost::format("<%s>") % _("empty")).str());
> +}
> +
> +// static
> MapData MapData::create_directory(const std::string& directory) {
> std::string localized_name;
> if (boost::equals(directory, "maps/MP_Scenarios")) {
> /** TRANSLATORS: Directory name for MP Scenarios in map
> selection */
> localized_name = _("Multiplayer Scenarios");
> + } else if (boost::equals(directory, "maps/My_Maps")) {
> + /** TRANSLATORS: Directory name for user maps in map selection
> */
> + localized_name = _("My Maps");
> } else {
> localized_name = FileSystem::fs_filename(directory.c_str());
> }
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1560454-mapdir/+merge/294725
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/bug-1560454-mapdir.
_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net/ListHelp
