Review: Approve
code lgtm. not tested.
Diff comments:
>
> === added file 'sitemap_urls.py'
> --- sitemap_urls.py 1970-01-01 00:00:00 +0000
> +++ sitemap_urls.py 2016-11-18 15:44:53 +0000
> @@ -0,0 +1,28 @@
> +from django.conf.urls import *
> +
> +from mainpage.views import mainpage
> +from django.contrib.sitemaps.views import sitemap
> +from static_sitemap import StaticViewSitemap
> +from wiki.sitemap import *
> +from news.sitemap import *
> +from pybb.sitemap import *
> +from wlhelp.sitemap import *
> +from sphinxdoc.sitemap import *
> +
> +sitemaps = {
> + 'static': StaticViewSitemap,
> + 'docs': DocumentationSitemap,
> + 'news': NewsSitemap,
> + 'wiki': WikiSitemap,
> + 'forum': ForumSitemap,
> + 'wlhelptribe': WlHelpTribeSitemap,
> + 'wlhelpware': WlHelpWareSitemap,
> + 'wlhelpworker': WlHelpWorkerSitemap,
> + 'wlhelpbuildings': WlHelpBuildingSitemap,
> + }
> +
consistency: you use two empty lines for top level elements below.
> +urlpatterns = [
> + # Creating a sitemap.xml
> + url(r'^$', sitemap, {'sitemaps': sitemaps},
> + name='django.contrib.sitemaps.views.sitemap')
> + ]
--
https://code.launchpad.net/~widelands-dev/widelands-website/sitemap/+merge/310261
Your team Widelands Developers is subscribed to branch lp:widelands-website.
_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net/ListHelp
