Review: Needs Fixing No, see diff comment.
Diff comments: > > === modified file 'data/scripting/richtext.lua' > --- data/scripting/richtext.lua 2017-12-27 14:25:35 +0000 > +++ data/scripting/richtext.lua 2018-01-05 12:13:24 +0000 > @@ -305,8 +305,8 @@ > -- :arg text: the text of the list item > -- > -- :returns: a p tag containing the formatted text > + > function li(text_or_symbol, text) > - if text then Removed if statement? The else clause below is superflous then? > return div(p(text_or_symbol)) .. div(p(space(6))) .. div("width=*", > p(text .. vspace(6))) > else > return div(p("•")) .. div(p(space(6))) .. div("width=*", > p(text_or_symbol .. vspace(6))) -- https://code.launchpad.net/~widelands-dev/widelands/fh1-scenario-groundwork-emp1/+merge/335294 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fh1-scenario-groundwork-emp1. _______________________________________________ Mailing list: https://launchpad.net/~widelands-dev Post to : widelands-dev@lists.launchpad.net Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp