Review: Approve code review, compile, short testplay
Reviewed the code (is currently compiling) OK.
And thanks those ai_help_structs.h annoyed me since quite some time.
Just one question inline.
Since there is no functional change I see no sense in doing any kind
of lengthy debugsession here.
Diff comments:
>
> === modified file 'src/wui/interactive_base.cc'
> --- src/wui/interactive_base.cc 2018-04-27 13:19:15 +0000
> +++ src/wui/interactive_base.cc 2018-04-28 14:48:46 +0000
> @@ -284,8 +284,8 @@
> toolbar_.add(button);
> if (window) {
> window->opened.connect(
> - [this, button] {
> button->set_style(UI::Button::Style::kPermpressed); });
> - window->closed.connect([this, button] {
> button->set_style(UI::Button::Style::kRaised); });
> + [button] {
> button->set_style(UI::Button::Style::kPermpressed); });
> + window->closed.connect([button] {
> button->set_style(UI::Button::Style::kRaised); });
Hiw can you omit 'this' without change in the code?
>
> if (bind_default_toggle) {
> button->sigclicked.connect(
--
https://code.launchpad.net/~widelands-dev/widelands/compiler_warnings_201804/+merge/344800
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/compiler_warnings_201804.
_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to : [email protected]
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net/ListHelp
