https://bugzilla.wikimedia.org/show_bug.cgi?id=16390
Summary: SubversionShell should always use --non-interactive
Product: MediaWiki extensions
Version: any
Platform: All
OS/Version: All
Status: NEW
Keywords: easy, patch
Severity: minor
Priority: Normal
Component: CodeReview
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]
Created an attachment (id=5534)
--> (https://bugzilla.wikimedia.org/attachment.cgi?id=5534)
a simple patch
Since SubversionShell is now able to pass --username and --password, it is not
that crucial, but still: svn should always be called with --non-interactive
(which is currently missing in getFile and getDiff).
Also, SubversionShell::getExtraArgs() should not require $wgSubversionPassword,
because somebody (like me in my local repository ;-) ) might have an empty
password.
See the attached patch.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
