https://bugzilla.wikimedia.org/show_bug.cgi?id=16502


Aryeh Gregor <[EMAIL PROTECTED]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[EMAIL PROTECTED]
                   |                            |m
             Status|RESOLVED                    |REOPENED
         Resolution|DUPLICATE                   |
            Summary|default skins don't show the|External link icons are not
                   |mail_icon,gif or            |displayed for RTL in
                   |external.png with another   |Monobook
                   |language file               |




--- Comment #3 from Aryeh Gregor <[EMAIL PROTECTED]>  2008-11-30 20:53:56 UTC 
---
Let's keep bug 3956 restricted to the user icon only, and keep this bug for the
external link icons.  They seem to be entirely different problems.  I can
confirm that the external link icons simply don't exist on RTL: e.g., look at

http://he.wikipedia.org/wiki/User:Simetrical/bug_16502

and note that there are no icons.  This should be some straightforward CSS to
fix, although it will probably result in code duplication.  The culpable code
is in skins/monobook/rtl.css:

/* Fix link icons */
.external {
        padding: 0 !important;
        background: none !important;
}

"Fix" in this case means just get rid of the icons, instead of bothering to get
them to display in the opposite direction.  To fix this, we'd want to copy over
all the link icon code, with padding and background direction changed.  We
could omit the actual URLs and stuff and just use background-position if we
liked, but we'd still have to re-specify the actual padding values, since it's
different for different icons.

The only reason I'd hesitate to do this is because they may have been dropped
because some browsers choke on them for some reason, due to some kind of
RTL-related bug.  This would require testing in all major browsers to avoid
regressions in appearance for RTL users.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to