https://bugzilla.wikimedia.org/show_bug.cgi?id=13209





--- Comment #14 from Roan Kattouw <roan.katt...@home.nl>  2008-12-15 18:59:54 
UTC ---
(In reply to comment #13)
> extractRowInfo($row) is bogus -- it's assuming that text.old_text contains the
> final wikitext of the revision, which is wrong. You *must* fetch text via the
> Revision class, or you'll break on compressed text, legacy encodings, cur row
> proxies, batch compression, or external storage.
> 

Yes, the patch is fundamentally flawed, we know about that. I'll mark it
obsolete.

The real question we have for you though is if you see any harm in clients
being able to pull 50 (500 for privileged users) diffs in one request,
considering they might have to be generated at that point. Is 50/500 diff
generations in one request evil enough to deny this feature?


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to