https://bugzilla.wikimedia.org/show_bug.cgi?id=15430
--- Comment #16 from Brion Vibber <br...@wikimedia.org> 2009-01-04 03:47:59 UTC --- This seems like it would be more likely to break, and in a less recoverable fashion. Current order of operations appears to be: 1) Physically move in the file 2) Save 'image'/'oldimage' record 3) Save log entry 4) Add/update description page Failing at the page save at least should leave us with a working file record, history, and log update, unless we hit a rare case where the actual image record update gets rolled back [if the log and page saves don't start any transactions, but then fail]. Order of operations for the patch is: 1) Physically move in the file 2) Add/update description page 3) Save 'image'/'oldimage' record 4) Save log entry If we fail at 2) now, we have a file sitting around with no record. If this is an update to an existing file, we have a broken history and an untraceable, unexplained, unlogged change -- very bad. Either we need to accept that failing the page is ok, or we need to be able to roll back the change to the actual file -- or else do it after, and be able to roll back all our DB and page updates if the file move fails. Icky. :( -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
