https://bugzilla.wikimedia.org/show_bug.cgi?id=32131
--- Comment #4 from Van de Bugger <van.de.bug...@gmail.com> 2011-11-02 19:36:38 UTC --- > Is this a patch against trunk? Yes. > And can you please not change var names all over the place and make a functional change at the same time? I change var name because the meaning of the variable is changed. I do not think it would be helpful to use $start variable for a character used for finishing list item. This is exact reason why I named it $itemFinish. > I honestly don't see where the current code is wrong, and how your patch fixes it. Let us consider lists of ul or ol types. makeList generates a newline at the front of each list item, and DOES NOT generate newline at the end of the last item, so result (before pass it to parseWikitext) will be intro...<div> * item1 * item2</div>outro Mwdiawiki parser allows </div>, but does not understand that </div> terminates the item, and generates intro...<div> <ul><li>item1 </li><li>item2</div>outro </li><ul> The problem can be solved by adding newline after the end of last item of the list: intro...<div> * item1 * item2<!-- This newline solves the issue. --> </div>outro So parser will generate intro...<div> <ul><li>item1 </li><li>item2 </li><ul> </div>outro -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
