https://bugzilla.wikimedia.org/show_bug.cgi?id=12837
Daniel Werner <danwe...@web.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |danwe...@web.de
--- Comment #7 from Daniel Werner <danwe...@web.de> 2011-11-08 17:02:13 UTC ---
The patch of attachment 4650 would break lots of compatibility, right now all
functions hooked in return 'true' (or otherwise break things), so if you only
return the $ret value on 'false' returned, all of the current calls, even if
they set $ret, imply they found nothing.
So the best compromise I think would be to always return $ret (it is set to
null before the wfRunHooks() call) and leave the 'false' handling to
wfRunHooks(), so returning 'false' simply would improve performance and won't
break things no longer in versions after the bugfix.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
