https://bugzilla.wikimedia.org/show_bug.cgi?id=32987
--- Comment #2 from Brion Vibber <br...@wikimedia.org> 2011-12-12 16:17:03 UTC
---
Took a quick peek, haven't tested yet.
A few offhand notes:
* I'm not sure I like adding more parameters to ThumbnailImage's constructor,
it feels like the whole thing should be refactored to take an array with a map
of params
* if no language is specified, language should probably default to the current
parsing context's content language -- this would allow eg an image from Commons
to simply be included as [[File:whatever.svg]] on fr.wikipedia.org without
manually adding |lang=fr. However this may add default params or otherwise be
funky...
* we're going to want ways to serve SVG files directly in which case we may
need to actually modify the file when serving a localized version; this'll
probably want some future infrastructure though so don't worry about it too
much yet.
* we may want to turn a lot of the magic words on files from handler-specific
things into generic items -- in which case we should make sure 'lang' is
available
* need some way to pass this lang parameter over the API for ForeignApiRepo
("InstantCommons"), so third-party sites using images from Commons can also use
the localization.
* thumbnail 404 handling _may_ need adjustment to match the extra lang
parameter. Need to check on status of this; we were talking about moving some
of the logic around.
Some specific notes:
* SvgHandler::parseParamString looks wrong; it assumes language codes are in
form ([a-z]{2,}). They may be more like ([a-z]+(?:-[a-z]+)*) -- extensions for
script or language variants (pt-br, zh-hans, etc).
* I'd recommend against having two variants of the magic word; stick with just
"lang" for simplicity
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
