https://bugzilla.wikimedia.org/show_bug.cgi?id=33746
--- Comment #10 from Krinkle <krinklem...@gmail.com> 2012-01-16 20:08:14 UTC --- (In reply to comment #9) > I think the numer of MW installations not using mw.util can be counted on one > hand. I doubt that. There has never been an automatic dependency on anything. If people "migrate" their gadgets to ResourceLoader and leave them broken by not declaring dependencies or some other important part of how ResourceLoader works, thats... unfortunate. But I'm sure that the gadgets we are "fixing" on labs are currently broken in production as well, just not as often (due to the race condition). Any gadget missing a dependency or a document ready hook will break at some point in some scenarios. And I get these reports all the time on IRC in #wikimedia-stewards or #mediawiki or wherever. 9/10 times is a copy/paste error not including the proper context or dependencies. Nothing new. Remember the report last year from IE6/IE7 users about $.cookie being undefined in Vector.js on en.wikipedia ? (I think Edokter discovered that one) That was very odd as it only happened to some users, but it turns out not to be a bug. That was a race condition and a missing dependency, IE6/7 loaded a bit slower. It was fixed then by not using $.cookie but the proper fix wouldl've been to simply add that module to do the dependencies. (In reply to comment #9) > But... Since MediaWiki:Common.css is *itself* a module, surely a dependency on > mediawiki.util can be declared when *it* loads? Sure it could be added as a dependency. And we probably should since so many users forgot to do it, but this is a very bad habbit to go into. I'd rather avoid it. I think its safe to say that there are no high usage site scripts or gadgets currently in production missing dependencies or document-ready hooks, otherwise we would've had complaints already as that code is technically broken as it is. Also, I'd recommend that whatever fixes we do on Labs, instead do them on the live wikis right away. Those fixes are not 1.18 of 1.19 specific. If a gadget isn't declaring their dependencies, it's probably wise to check it out further as there's a good chance there's other copy/paste errors. [1] https://meta.wikimedia.org/wiki/User:Krinkle/Le_Tour_de_Wik%C3%AD/1-17-allwikis -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
