https://bugzilla.wikimedia.org/show_bug.cgi?id=33952
Web browser: ---
Bug #: 33952
Summary: move (old) toolbar init script to Ressource Loader
Product: MediaWiki
Version: 1.18
Platform: All
OS/Version: All
Status: NEW
Severity: major
Priority: Unprioritized
Component: Javascript
AssignedTo: wikibugs-l@lists.wikimedia.org
ReportedBy: a.d.be...@web.de
CC: krinklem...@gmail.com, m...@everybody.org,
mybugs.m...@gmail.com, tpars...@wikimedia.org
Classification: Unclassified
Continuing Bug Bug 31511#6
> http://en.wikipedia.org/w/index.php?diff=454405866
> http://en.wikipedia.org/w/index.php?diff=454588601&oldid=454587788
Two reports about a not well initialised toolbar. I think I found a reason:
The current implementation puts out a inline script tag with the
RessourceLoader-call for certain modules, amongst them mw.action.edit. Right
after that comes another inline script, which checks the existance of
window.mediawiki and then addsButtons() to the toolbar. On-DOM-Ready then the
mw.toolbar.inits().
One concern I have is that the second inline script shouldn't rely on the RL
module, which might be loaded and executed asynchronously in newer browsers in
special cases.
Also, it is very hard for scripts like the XEB-gadget to execute a function
between the addButton-calls, which register the default buttons, and the init()
function that creates the buttons.
So I'd propose to create a own ressource loader module for the default buttons.
I can't see any reason why this is still an inline script; we might even put it
together with the mw.toolbar code.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
