https://bugzilla.wikimedia.org/show_bug.cgi?id=33545
Bawolff <bawolff...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|need-review |reviewed
--- Comment #10 from Bawolff <bawolff...@gmail.com> 2012-02-12 01:50:51 UTC ---
Sorry for the delay. Some comments:
*It'd probably be a good idea to run svn up before submitting a patch, just
because people make changes to code base as time goes on (In this case somebody
migrated ListUser's to use RequestContext which changed some variable names
from $wgRequest to $request).
*As I mentioned before, a new message should be used for the checkbox label
(instead of doing wfMsg( 'blocklist-tempblocks') ). You can add a new message
by adding an entry to the giant array at
/includes/langauges/messages/MessagesEn.php (Any new message should have a
quick documentation entry in includes/langauges/messages/MessagesQqq.php to
help the translators. You don't have to worry about the other message files,
the translators will translate the message in due time).
*This currently would also get people who have temp blocked that are now
expired (such entries eventually get removed from the ipblocks table, but not
immediatly)
It will need some sort of condition in the conds[] array, as an OR to the is
NULL condition, that's something like 'ipb_deleted = 0 and ipb_expiry < ' .
$dbr->addQuotes( $dbr->timestamp( wfTimestampNow() ) ) in order to catch
already expired blocks
(which should work for infinite blocks since infinite supposedly sorts after
all timestamps).
Otherwise, it looks like a very good start.
Other possibilities with this feature include the possibility of adding a css
class to blocked users (when not filtering by blocked) so people could style
them greyed out if they wanted.
Another thing to consider for this, do we want separate check boxes for hiding
people blocked indefinitly vs people just blocked (temporarily) or should we
just have one checkbox for all blocks (since more broad), or should we only
allow filtering out indef blocked users (on the notion that temp blocked folks
are being punished, but indef folks are permenantly kicked out). Having two
boxes seems a little clutery in my opinion, but I'm not really sure.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
